doc: Update bips.md for 0.19 #16997

pull laanwj wants to merge 4 commits into bitcoin:master from laanwj:2019_09_bips_v19 changing 2 files +5 −4
  1. laanwj commented at 1:15 PM on September 30, 2019: member
    • Add mention of BIP70 disabling by default at build time.

    Any others?

    E.g. does the burying of deployments of #16060 need to be mentioned? If so, where and how? For all of BIPs 34, 65 and 66?

  2. laanwj added the label Docs on Sep 30, 2019
  3. laanwj added this to the milestone 0.19.0 on Sep 30, 2019
  4. MarcoFalke commented at 1:26 PM on September 30, 2019: member

    Could also link to the buried deployments pull request?

    See

    • ab0c35a290b8cb05b9bed0c24627bcc98bb22b2b
    • e78aaf41f43d0e2ad78fa6d8dad61032c8ef73d0
  5. MarcoFalke commented at 1:26 PM on September 30, 2019: member

    ACK bcdab14673fd421fe3441980a0e50cce087420c2

  6. laanwj commented at 1:29 PM on September 30, 2019: member

    Could also link to the buried deployments pull request?

    Yes, but whether to put it under BIP9 or the affected deployment BIPs?

  7. MarcoFalke commented at 2:29 PM on September 30, 2019: member

    It could be appended to each deployment, similar to how ab0c35a did it.

  8. laanwj force-pushed on Sep 30, 2019
  9. doc: Add mention of BIP70 disabling by default in bips.md b11514d4e5
  10. laanwj force-pushed on Sep 30, 2019
  11. laanwj commented at 2:52 PM on September 30, 2019: member

    I've decided to do both. Should be ready now.

  12. Sjors commented at 3:49 PM on September 30, 2019: member

    A few potential improvements:

    • BIP 125 is used by the wallet, enabled by default in GUI as of v0.18.1 (PR #11605)
    • BIP 158 Compact Block Filters for Light Clients can be indexed as of v0.19.0 (PR #14121)
  13. in doc/bips.md:3 in 4cadf01d73 outdated 
       0 | @@ -1,6 +1,6 @@
   1 |  BIPs that are implemented by Bitcoin Core (up-to-date up to **v0.18.0**):
   2 |  
   3 | -* [`BIP 9`](https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki): The changes allowing multiple soft-forks to be deployed in parallel have been implemented since **v0.12.1**  ([PR #7575](https://github.com/bitcoin/bitcoin/pull/7575))
   4 | +* [`BIP 9`](https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki): The changes allowing multiple soft-forks to be deployed in parallel have been implemented since **v0.12.1**  ([PR #7575](https://github.com/bitcoin/bitcoin/pull/7575)). The BIP 9 activation for BIPs 34, 65 and 66 was buried (hardcoded) in *v0.19.0* ([PR #16060](https://github.com/bitcoin/bitcoin/pull/16060)).
    MarcoFalke commented at 3:57 PM on September 30, 2019:

    No strong opinion, but the fact that BIP 9 was responsible for their activation might be controversial. See e.g. https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-August/017267.html

    laanwj commented at 6:22 PM on September 30, 2019:

    OK, removing that then

  14. in doc/bips.md:14 in 4cadf01d73 outdated 
      10 | @@ -11,15 +11,15 @@ BIPs that are implemented by Bitcoin Core (up-to-date up to **v0.18.0**):
  11 |  * [`BIP 30`](https://github.com/bitcoin/bips/blob/master/bip-0030.mediawiki): The evaluation rules to forbid creating new transactions with the same txid as previous not-fully-spent transactions were implemented since **v0.6.0**, and the rule took effect on *March 15th 2012* ([PR #915](https://github.com/bitcoin/bitcoin/pull/915)).
  12 |  * [`BIP 31`](https://github.com/bitcoin/bips/blob/master/bip-0031.mediawiki): The 'pong' protocol message (and the protocol version bump to 60001) has been implemented since **v0.6.1** ([PR #1081](https://github.com/bitcoin/bitcoin/pull/1081)).
  13 |  * [`BIP 32`](https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki): Hierarchical Deterministic Wallets has been implemented since **v0.13.0** ([PR #8035](https://github.com/bitcoin/bitcoin/pull/8035)).
  14 | -* [`BIP 34`](https://github.com/bitcoin/bips/blob/master/bip-0034.mediawiki): The rule that requires blocks to contain their height (number) in the coinbase input, and the introduction of version 2 blocks has been implemented since **v0.7.0**. The rule took effect for version 2 blocks as of *block 224413* (March 5th 2013), and version 1 blocks are no longer allowed since *block 227931* (March 25th 2013) ([PR #1526](https://github.com/bitcoin/bitcoin/pull/1526)).
  15 | +* [`BIP 34`](https://github.com/bitcoin/bips/blob/master/bip-0034.mediawiki): The rule that requires blocks to contain their height (number) in the coinbase input, and the introduction of version 2 blocks has been implemented since **v0.7.0**. The rule took effect for version 2 blocks as of *block 224413* (March 5th 2013), and version 1 blocks are no longer allowed since *block 227931* (March 25th 2013) ([PR #1526](https://github.com/bitcoin/bitcoin/pull/1526)). The BIP 9 activation for this softfork was buried (hardcoded) in *v0.19.0* ([PR #16060](https://github.com/bitcoin/bitcoin/pull/16060)).
    MarcoFalke commented at 3:59 PM on September 30, 2019:

    bip 34 was buried in bip 90 (a different pull request). See e.g #9879

    laanwj commented at 6:23 PM on September 30, 2019:

    OK, will revert that change.

  15. DrahtBot commented at 5:19 PM on September 30, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15437 (p2p: Remove BIP61 reject messages by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  16. laanwj force-pushed on Sep 30, 2019
  17. laanwj commented at 6:25 PM on September 30, 2019: member

    I've removed the commit about the BIP 9 deployments, will leave writing that to someone else.

    Edit: @Sjors thanks, added.

  18. doc: Add mention of BIP125 used by wallet GUI by default since v0.18.1 226700602b
  19. doc: Add mention of BIP158 indexing since v0.19.0 82c11773dc
  20. MarcoFalke commented at 7:03 PM on September 30, 2019: member

    ACK 82c11773dc7493e1863b3b8277958f744a321eb9

  21. hebasto commented at 7:14 PM on September 30, 2019: member

    Concept ACK.

    In the first line

    BIPs that are implemented by Bitcoin Core (up-to-date up to **v0.18.0**):

    s/18/19/

  22. MarcoFalke commented at 7:25 PM on September 30, 2019: member

    s/18/19/

    Might want to mention the version bump in the release process? https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-every-major-and-minor-release

  23. doc: Bump version in bips.md, mention bumping in release process 60e855f5c5
  24. hebasto commented at 5:26 AM on October 1, 2019: member

    ACK 60e855f5c50c4578bbab93282226f236853491dc

  25. laanwj referenced this in commit a54e52b4ae on Oct 1, 2019
  26. laanwj merged this on Oct 1, 2019
  27. laanwj closed this on Oct 1, 2019
  28. sidhujag referenced this in commit c4a8725587 on Oct 2, 2019
  29. Munkybooty referenced this in commit e136fbc6e3 on Dec 9, 2021
  30. DrahtBot locked this on Dec 16, 2021
Contributors
laanwjMarcoFalkeSjorsDrahtBothebasto
Labels
Docs

Milestone
0.19.0

Linked (view graph)
#16060 Bury bip9 deployments#16996 Release process for 0.19.0
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me