I ran autopep8 --in-place --select=W293 --recursive . to find this.
script: Remove trailing whitespace on blank lines. #17003
pull jbampton wants to merge 1 commits into bitcoin:master from jbampton:remove-whitespace changing 1 files +64 −64-
jbampton commented at 9:11 PM on September 30, 2019: contributor
-
679f11f0f0
Remove trailing whitespace on blank line.
I ran `autopep8 --in-place --select=W293 --recursive .` to find this.
- DrahtBot added the label Scripts and tools on Sep 30, 2019
- jbampton renamed this:
Remove trailing whitespace on blank lines.
script: Remove trailing whitespace on blank lines.
on Sep 30, 2019 -
jonatack commented at 11:51 PM on September 30, 2019: member
I could be wrong, but my understanding has been that changes like this are maybe ok when they are done alongside more important changes involving the file. doc/developer-notes.md: "Do not submit patches solely to modify the style of existing code." CONTRIBUTING.md: "Trivial pull requests or pull requests that refactor the code with no clear benefits may be immediately closed by the maintainers to reduce unnecessary workload on reviewing." YMMV.
-
promag commented at 11:57 PM on September 30, 2019: member
Don't care that much ACK, https://github.com/bitcoin/bitcoin/pull/17003/files?w=1.
-
laanwj commented at 7:55 AM on October 1, 2019: member
Thanks for wanting to contribute, but PRs need to fix actual problems (preferably, issues that have been filed). We do not accept PRs like this that just manipulate whitespace.
- laanwj closed this on Oct 1, 2019
- jbampton deleted the branch on Oct 1, 2019
- DrahtBot locked this on Dec 16, 2021
Labels