contrib/linearize scripts need tests #17019

issue laanwj openend this issue on October 2, 2019
  1. laanwj commented at 8:28 am on October 2, 2019: member

    The scripts under contrib/linearize do not have any tests.

    It would be good to have functional tests for them, to assure that they keep working, and so that changes to them are not necessarily held up on manual testing.

  2. laanwj added the label Tests on Oct 2, 2019
  3. laanwj added the label Scripts and tools on Oct 2, 2019
  4. laanwj added the label good first issue on Oct 2, 2019
  5. fjahr commented at 4:29 pm on October 9, 2019: member
    For reference: I am working on a test for the -loadblock option in #17044 and the scripts are implicitly tested in it. @laanwj do you have hints on configurations you think should be tested in particular?
  6. MarcoFalke commented at 4:46 pm on October 9, 2019: member
    It looks like the test can be submitted without the code changes and should still pass? If so, maybe do that as a first, separate, pull request?
  7. MarcoFalke commented at 5:20 pm on October 9, 2019: member
    I ran git checkout 6a768e516e3bafe31bd8c0792cdc93986cabcc56 && ./test/functional/feature_loadblock.py and it passed, so seems fine to do
  8. fjahr commented at 10:58 pm on October 9, 2019: member

    It looks like the test can be submitted without the code changes and should still pass? If so, maybe do that as a first, separate, pull request?

    Yeah, the test got much larger than the inital improvement of #15954 so makes sense: #17091

  9. laanwj closed this on Oct 23, 2019

  10. sidhujag referenced this in commit 3e3f53b757 on Oct 26, 2019
  11. MarcoFalke locked this on Dec 16, 2021
  12. Munkybooty referenced this in commit 98325fcf26 on Apr 29, 2022
  13. Munkybooty referenced this in commit 7e77f6db47 on May 12, 2022
  14. Munkybooty referenced this in commit 84d7b7cace on May 12, 2022
  15. Munkybooty referenced this in commit bbf79db207 on May 17, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me