the translations of Traditional Chinese in bitcoin_zh_TW.ts got clobbered to Simplified Chinese #17027

issue r8921039 opened this issue on October 2, 2019
  1. r8921039 commented at 7:34 PM on October 2, 2019: contributor 
    commit 977dd23e4023ac2f6cbbe86eb769db079b8018be
Author: Wladimir J. van der Laan <laanwj@protonmail.com>
Date:   Mon Sep 30 09:41:11 2019 +0200

    qt: Periodic translations update
    
    Pull new translations from Transifex and run `make translate`.

diff --git a/src/qt/locale/bitcoin_zh_TW.ts b/src/qt/locale/bitcoin_zh_TW.ts
index 635151bcc..0a6e5d605 100644
--- a/src/qt/locale/bitcoin_zh_TW.ts
+++ b/src/qt/locale/bitcoin_zh_TW.ts
@@ -3,487 +3,451 @@
     <name>AddressBookPage</name>
     <message>
         <source>Right-click to edit address or label</source>
-        <translation>右鍵點一下來修改位址或標記</translation>
+        <translation>鼠标右击编辑地址或标签</translation>
     </message>
     <message>
         <source>Create a new address</source>
-        <translation>產生一個新位址</translation>
+        <translation>创建新地址</translation>
     </message>
     <message>
  2. r8921039 added the label Bug on Oct 2, 2019
  3. fanquake added the label GUI on Oct 2, 2019
  4. fanquake added this to the milestone 0.19.0 on Oct 2, 2019
  5. r8921039 commented at 7:38 PM on October 2, 2019: contributor

    note: bitcoin_zh_TW.ts is for Taiwan

  6. MarcoFalke commented at 8:24 PM on October 2, 2019: member

    The translation is here: https://www.transifex.com/bitcoin/bitcoin/viewstrings/#zh_TW/qt-translation-019x/181450170

    However, I am not a translator for this language, so I can't see any details

  7. r8921039 commented at 9:04 PM on October 2, 2019: contributor

    The translation is here: https://www.transifex.com/bitcoin/bitcoin/viewstrings/#zh_TW/qt-translation-019x/181450170

    I just set up a Transifex account. Applying "filters" on the web shows the first/initial version is available since 2019-09-02 (nothing shows up with criteria 'translated_before: 2019-09-01') and most of the translations contain the incorrect simplified Chinese already in the first/initial version. Wonder how the first/initial version was created? It would be correct if making v18 translations as default.

  8. r8921039 commented at 9:16 PM on October 2, 2019: contributor

    the v18 zh_TW translation on Transifax is incorrect as well: https://www.transifex.com/bitcoin/bitcoin/viewstrings/#zh_TW/qt-translation-018x/163802850

    however, the bitcoin-core v18 release is not affected (yet) as v18 translation hasn't been updated since Mar 14 2019 a01925c1502a4f74c01905b2b38d8f8a5ce975b1

  9. laanwj commented at 2:57 AM on October 3, 2019: member

    This needs to be fixed on transifex, then we can re-import the fixed translations.

  10. r8921039 commented at 5:25 PM on October 3, 2019: contributor

    Is it possible to set/reset to the correct defaults first on Transifex? Or do we have to fix all translations manually for each release version (v18, v19 and future releases) on Transifex?

  11. r8921039 commented at 5:48 PM on October 3, 2019: contributor

    BTW, v17 on Transifax looks much better and I see it is locked.

  12. r8921039 commented at 5:50 PM on October 3, 2019: contributor

    the best case is that we can restore the correct transactions for v18 and then use it as the initial template for v19 and onward.

  13. MarcoFalke commented at 5:51 PM on October 3, 2019: member

    So is this an issue with transifex or with a translator or something else?

  14. MarcoFalke commented at 5:58 PM on October 3, 2019: member

    @laanwj Are you doing anything special importing the existing translations to new major versions?

  15. MarcoFalke commented at 5:59 PM on October 3, 2019: member

    Anyway, I don't speak Chinese nor Taiwanese, but the 0.17 translations shows up as a 101% match, so I went ahead and switched to it.

    Screenshot from 2019-10-03 13-56-58

  16. r8921039 commented at 6:05 PM on October 3, 2019: contributor

    Thanks @MarcoFalke, the 2nd option looks legit!

  17. r8921039 commented at 6:19 PM on October 3, 2019: contributor

    Anyway, I don't speak Chinese nor Taiwanese, but the 0.17 translations shows up as a 101% match, so I went ahead and switched to it.

    Screenshot from 2019-10-03 13-56-58

    Somehow this only fixed one string, 921 to go... I wish there is a way to fix things wholesale.

  18. MarcoFalke commented at 6:28 PM on October 3, 2019: member

    Ouch, so pretty much all of these are incorrect: https://github.com/bitcoin/bitcoin/commit/977dd23e4023ac2f6cbbe86eb769db079b8018be#diff-08bf2442f2fcd6a33d39c5e6f48df61f

    Hmm

  19. r8921039 commented at 6:35 PM on October 3, 2019: contributor

    Yes, sorry I wasn't clear on the post.

  20. laanwj commented at 6:58 PM on October 3, 2019: member

    @laanwj Are you doing anything special importing the existing translations to new major versions?

    Yes, I have a clone-resource script that copies the translations as well as metadata to a new resource, so in this case from 0.18 to 0.19 (but this only works once, when the resource is still empty).

  21. laanwj commented at 7:01 PM on October 3, 2019: member

    As a brute-force approach you could try uploading the appropriate ts from the 0.18 branch to transifex for 0.19. This will erase all the translator metadata but will reset the translations for all the messages that were already present in 0.18.

  22. MarcoFalke commented at 7:01 PM on October 3, 2019: member

    Is that open source? There might be a bug in it

  23. MarcoFalke commented at 7:38 PM on October 3, 2019: member

    @GChuf Any idea why this happened?

  24. MarcoFalke commented at 7:41 PM on October 3, 2019: member

    I wonder if other languages are also affected

  25. r8921039 commented at 12:21 AM on October 4, 2019: contributor

    Many thanks @laanwj @MarcoFalke, the file is looking great on Transifex for v18/v19 now.

  26. laanwj referenced this in commit 6db76c6bc7 on Oct 4, 2019
  27. GChuf commented at 10:05 AM on October 4, 2019: contributor

    @MarcoFalke I can't say how/why it happened, but it must be a human mistake. Someone must have deleted the taiwanese v18 on transifex and upload chinese translation instead. Honestly, it might have been me, although I don't remember deleting any chinese/taiwanese translations (except deleting zh_CN.GB2312 I think, and I chose to keep both zh and zh_CN unlike with any other language). So if I did, it was an error in the first place deleting the taiwanese translations, and another error when reuploading the wrong translations, so I don't think that was me ...

    Anyway, I see laanwj already fixed it with reuploading v18 from github to transifex, which is what I would also have suggested.

    The thing is, anyone could do this with any language, which is an issue. @laanwj right now any translator can delete all translations and reupload a file - do you think you could restrain that?

  28. laanwj commented at 11:31 AM on October 4, 2019: member

    The thing is, anyone could do this with any language, which is an issue. @laanwj right now any translator can delete all translations and reupload a file - do you think you could restrain that?

    The least dramatic way to restrict translation changes would be to require review. (the other way, to down translations would be to close the translation teams and allow only vetted translators, but honestly I see no way to organize that in a volunteer-run open source project)

  29. MarcoFalke referenced this in commit fa60a85c38 on Oct 4, 2019
  30. MarcoFalke closed this on Oct 4, 2019
  31. r8921039 commented at 3:49 PM on October 4, 2019: contributor

    @laanwj @MarcoFalke Just did some git pull's. I see now it is fixed on v18/v19 release branches but the master is still having the incorrect one (just wanna make sure the master won't be used as v20 defaults).

  32. r8921039 commented at 3:53 PM on October 4, 2019: contributor

    my concern on update master is discussed here #17049

  33. MarcoFalke commented at 4:35 PM on October 4, 2019: member

    I believe v19 will be used as default for v20, not master, but I will leave it to @laanwj whether to cherry-pick commit 6db76c6 to master or not.

  34. fanquake referenced this in commit 7b701fef58 on Oct 4, 2019
  35. laanwj commented at 9:28 AM on October 5, 2019: member

    I believe v19 will be used as default for v20, not master,

    Yes. Translation updates should happen for major version branches, not for master. Master has no active translations until the start of the next release window. At which start the current actual translations will be copied on transifex, not from the branch.

    (I'm fine with cherry-picking a special case, if you're running master and it annoys you, but it's pointless to the release process)

  36. fxtc referenced this in commit ba258aa09f on Nov 25, 2019
  37. fxtc referenced this in commit 4681ee16a4 on Nov 25, 2019
  38. MarcoFalke locked this on Dec 16, 2021
  39. knst referenced this in commit 7c9c9a531f on Mar 24, 2023
  40. knst referenced this in commit 59aa122620 on Mar 29, 2023
  41. UdjinM6 referenced this in commit b696fb16c7 on Apr 6, 2023
Contributors
r8921039MarcoFalkelaanwjGChuf
Labels
BugGUI

Milestone
0.19.0

Linked (view graph)
#17049 contrib: Bump gitian descriptors for 0.20#17058 GUI: Remove old translation files, reorganize translations
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me