Don't rename main thread at process level #17038

1. 
   laanwj commented at 4:10 AM on October 3, 2019: member

   Set only the internal name for the main threads.

   Fixes #17036 for both bitcoind and bitcoin-qt.

   After this, e.g. killall works again for either.

2. laanwj added the label Utils/log/libs on Oct 3, 2019
3. laanwj added this to the milestone 0.19.0 on Oct 3, 2019
4. laanwj force-pushed on Oct 3, 2019
5. Don't rename main thread at process level

   Set only the internal name.
   
   Fixes #17036 for both `bitcoind` and `bitcoin-qt`.

   07e4bdba3b
6. laanwj force-pushed on Oct 3, 2019
7. 
   laanwj commented at 4:59 AM on October 3, 2019: member

   Ugh, I suppose this was added to set the internal name for logging. Pushed an alternative approach.

8. laanwj renamed this:
   Don't call ThreadRename for the main thread
   Don't rename main thread at process level
   on Oct 3, 2019
9. 
   hebasto commented at 5:30 AM on October 3, 2019: member

   Concept ACK

10. 
    promag commented at 9:47 AM on October 3, 2019: member

    Tested ACK 07e4bdba3bd46c3a15dedb0a2660453c300643dc, killall bitcoind and killall bitcoin-qt now just works!

11. 
    jonatack commented at 9:58 AM on October 3, 2019: member

    Thanks for this; I tripped on this recently and wondered what was the issue. Testing.

12. 
    jonatack commented at 10:39 AM on October 3, 2019: member

    ACK 07e4bdba3bd46c3a15dedb0a2660453c300643dc killall bitcoind shuts down bitcoind mainnet/testnet/regtest, killall bitcoin-qt shuts down ./src/qt/bitcoin-qt, tests pass, very light code review. Good idea to add the @note warning. Thanks!

13. MarcoFalke added the label Needs backport on Oct 3, 2019
14. laanwj referenced this in commit 4715037796 on Oct 3, 2019
15. laanwj merged this on Oct 3, 2019
16. laanwj closed this on Oct 3, 2019

    ---

17. laanwj referenced this in commit 9fdaaecf49 on Oct 3, 2019
18. laanwj removed the label Needs backport on Oct 3, 2019
19. hebasto approved
20. 
    hebasto commented at 7:00 PM on October 3, 2019: member

    ACK 07e4bdba3bd46c3a15dedb0a2660453c300643dc, I have tested the code on Linux Mint 19.2: killall {bitcoind|bitcoin-qt} works as expected (even with bash completion).

    Also, ps outputs for bitcoin-qt (as example) with this PR:

    $ ps
      PID TTY          TIME CMD
     3137 pts/0    00:00:00 bash
    17072 pts/0    00:00:07 bitcoin-qt
    17100 pts/0    00:00:00 ps
    

    $ ps -T
      PID  SPID TTY          TIME CMD
     3137  3137 pts/0    00:00:00 bash
    17072 17072 pts/0    00:00:00 bitcoin-qt
    17072 17073 pts/0    00:00:00 QXcbEventReader
    17072 17074 pts/0    00:00:00 bitcoin:disk$0
    17072 17075 pts/0    00:00:00 QDBusConnection
    17072 17076 pts/0    00:00:00 gmain
    17072 17077 pts/0    00:00:00 gdbus
    17072 17078 pts/0    00:00:07 b-qt-init
    17072 17079 pts/0    00:00:00 b-scriptch.0
    17072 17080 pts/0    00:00:00 b-scriptch.1
    17072 17081 pts/0    00:00:00 b-scriptch.2
    17072 17082 pts/0    00:00:00 b-scheduler
    17072 17083 pts/0    00:00:00 b-http
    17072 17084 pts/0    00:00:00 b-httpworker.0
    17072 17085 pts/0    00:00:00 b-httpworker.1
    17072 17086 pts/0    00:00:00 b-httpworker.2
    17072 17087 pts/0    00:00:00 b-httpworker.3
    17072 17088 pts/0    00:00:00 b-qt-init
    17072 17090 pts/0    00:00:00 b-torcontrol
    17072 17091 pts/0    00:00:00 b-upnp
    17072 17092 pts/0    00:00:00 b-net
    17072 17093 pts/0    00:00:00 b-dnsseed
    17072 17094 pts/0    00:00:00 b-addcon
    17072 17095 pts/0    00:00:00 b-opencon
    17072 17096 pts/0    00:00:00 b-msghand
    17072 17097 pts/0    00:00:00 QThread
    17072 17098 pts/0    00:00:00 QThread
    17105 17105 pts/0    00:00:00 ps
    

21. 
    MarcoFalke commented at 7:11 PM on October 3, 2019: member

    ACK

22. sidhujag referenced this in commit 04b06427bf on Oct 4, 2019
23. HashUnlimited referenced this in commit 3fa7513e06 on Nov 17, 2019
24. fxtc referenced this in commit de31dc95d3 on Nov 25, 2019
25. fxtc referenced this in commit ce2b1d6dcc on Nov 25, 2019
26. deadalnix referenced this in commit 65e33fdc9e on Mar 24, 2020
27. ftrader referenced this in commit 2ac5ab36d5 on Dec 1, 2020
28. PastaPastaPasta referenced this in commit 769974f3db on Sep 21, 2021
29. kittywhiskers referenced this in commit 72e2e244eb on Oct 12, 2021
30. vijaydasmp referenced this in commit 6f4bf99236 on Dec 6, 2021
31. MarcoFalke locked this on Dec 16, 2021

Contributors

laanwjhebastopromagjonatackMarcoFalke

Milestone
0.19.0