Updates headers for version 0.19 with the updated "copyright_header.py" script. It now includes .sh and .bash-completion files as well.
Update headers for v0.19 #17053
pull GChuf wants to merge 1 commits into bitcoin:0.19 from GChuf:update-headers-019 changing 287 files +287 −287-
GChuf commented at 2:57 PM on October 4, 2019: contributor
-
emilengler commented at 3:17 PM on October 4, 2019: contributor
Concept NACK. The planned release date is
2020-01-03. This means that there might be some code changes in 2020 as well. I think that this script should executed at the end of every year and SHORTLY before a release. @laanwj When you do the final commits, could you run this script again? -
emilengler commented at 3:27 PM on October 4, 2019: contributor
Also running this script to often is not a good approach. You are changing 287 files which means that if a user is currently working on a file which was changed by you he would need to rebase which wouldn't be the effort worth in my opinion. Sorry.
- fanquake closed this on Oct 4, 2019
-
Update headers for v0.19 4038b714fd
-
laanwj commented at 9:23 AM on October 5, 2019: member
AFAIK the current way of working is to run this script at the end of a year on master only. It doesn't really have anything to do with the release cycle.
-
emilengler commented at 9:27 PM on October 5, 2019: contributor
@laanwj IIRC @DrahtBot runs opens a PR for this every year. However in #16789 @MarcoFalke said that this should be done before every new release. I agree with this because the release is also delivered as a (de-facto) tarball and it should correct there as well. So I would suggest to add this process to the release process as well
-
laanwj commented at 8:48 AM on October 6, 2019: member
I don't agree. I don't care if the copyright years are a year off (and the downsides is that it can cause merge conflicts).
- GChuf deleted the branch on Oct 9, 2019
- DrahtBot locked this on Dec 16, 2021
Contributors