gui: RPC responses should not be translated #17072

1. 
   MarcoFalke commented at 2:43 pm on October 7, 2019: member

   Steps to reproduce:

    0$ XDG_SESSION_TYPE=""  QT_QPA_PLATFORM=minimal LC_ALL=de_DE.UTF-8 BITCOIND=bitcoin-qt ./test/functional/wallet_basic.py 
    12019-10-07T14:43:13.778000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_or0h2c7y
    22019-10-07T14:43:15.630000Z TestFramework (INFO): Mining blocks...
    32019-10-07T14:43:17.819000Z TestFramework (INFO): test gettxout
    42019-10-07T14:43:17.842000Z TestFramework (INFO): test gettxout (second part)
    52019-10-07T14:43:18.896000Z TestFramework (ERROR): Assertion failed
    6Traceback (most recent call last):
    7  File "/home/marco/workspace/btc_bitcoin_core/test/functional/test_framework/util.py", line 122, in try_rpc
    8    fun(*args, **kwds)
    9  File "/home/marco/workspace/btc_bitcoin_core/test/functional/test_framework/coverage.py", line 47, in __call__
   10    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
   11  File "/home/marco/workspace/btc_bitcoin_core/test/functional/test_framework/authproxy.py", line 141, in __call__
   12    raise JSONRPCException(response['error'], status)
   13test_framework.authproxy.JSONRPCException: Ungenügendes Guthaben (-4)
   14
   15During handling of the above exception, another exception occurred:
   16
   17Traceback (most recent call last):
   18  File "/home/marco/workspace/btc_bitcoin_core/test/functional/test_framework/test_framework.py", line 194, in main
   19    self.run_test()
   20  File "./test/functional/wallet_basic.py", line 120, in run_test
   21    assert_raises_rpc_error(-4, "Insufficient funds", self.nodes[2].sendtoaddress, self.nodes[2].getnewaddress(), 20)
   22  File "/home/marco/workspace/btc_bitcoin_core/test/functional/test_framework/util.py", line 114, in assert_raises_rpc_error
   23    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
   24  File "/home/marco/workspace/btc_bitcoin_core/test/functional/test_framework/util.py", line 130, in try_rpc
   25    message, e.error['message']))
   26AssertionError: Expected substring not found in error message:
   27substring: 'Insufficient funds'
   28error message: 'Ungenügendes Guthaben'.
   

2. MarcoFalke added the label Bug on Oct 7, 2019
3. MarcoFalke added the label GUI on Oct 7, 2019
4. laanwj added the label RPC/REST/ZMQ on Oct 15, 2019
5. 
   laanwj commented at 12:06 pm on October 15, 2019: member

   Crap. Does the bilingual message stuff help to address this?
6. 
   MarcoFalke commented at 3:01 pm on October 15, 2019: member

   Crap. Does the bilingual message stuff help to address this?

   It does.

   I have fixes for it locally, but I won’t submit them before #17070 is merged, as both bugfixes conflict with each other.

7. laanwj closed this on May 4, 2020

   ---

8. sidhujag referenced this in commit a2b5fc738d on May 4, 2020
9. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke laanwj

Labels
Bug GUI RPC/REST/ZMQ