GUI: rename "debug window" #17082

issue jonasschnelli opened this issue on October 9, 2019

jonasschnelli commented at 9:32 AM on October 9, 2019: contributor

The term "Debug Window" is not accurate IMO and we should consider renaming it to a more user-friendly term (only visible in the window title as well as from the tray menu).
jonasschnelli added the label GUI on Oct 9, 2019
jonasschnelli added the label good first issue on Oct 9, 2019
laanwj commented at 9:34 AM on October 9, 2019: member

Instead of a debug window, it has pretty much become the Node UI (in contrast to the Wallet UI, that is the main window) over time. Neither of these are user-friendly terms but this is a concept ACK.
promag commented at 9:37 AM on October 9, 2019: member

pretty much become the Node UI

🤔 that could be the internal name class NodeWidget instead of class RPCConsole.
MarcoFalke added the label Hacktoberfest on Oct 9, 2019
Relaxo143 commented at 8:37 PM on October 9, 2019: none

Instead of a debug window, it has pretty much become the Node UI (in contrast to the Wallet UI, that is the main window) over time. Neither of these are user-friendly terms but this is a concept ACK.

"Node Window" or "Node Menu" sound good to me.
Zero-1729 commented at 9:02 AM on October 10, 2019: contributor

Would that mean all references to debugwindow would change to nodewindow, RPCConsole to NodeWidget, openRPCConsoleAction to openNodeWidgetAction, etc?

Also, is anyone working on this?
promag commented at 9:07 AM on October 10, 2019: member

@Zero-1729 feel free to work on that.
Zero-1729 commented at 9:37 AM on October 10, 2019: contributor
Awesome 👍

... we should consider renaming it to a more user-friendly term (only visible in the window title as well as from the tray menu).

As per @jonasschnelli's original message above, should the change just be limited to changing where 'Debug window' is displayed to 'Node window', i.e:

in src/qt/forms/debugWindow.ui:
```
<?xml version="1.0" encoding="UTF-8"?>
<ui version="4.0">
 <class>RPCConsole</class>
 <widget class="QWidget" name="RPCConsole">
...
  <property name="windowTitle">
   <string>Node window</string> <- here
...
```
and in src/qt/bitcoingui.cpp :
```
...
openNodeWidgetAction = new QAction(tr("&Node window"), this); <- here
    openNodeWidgetAction->setStatusTip(tr("Open node debugging and diagnostic console"));
...
```
promag commented at 9:55 AM on October 10, 2019: member
@Zero-1729 hard to tell, at least separate in commits:
- change titles/labels/menus
- class rename
- filen rename
Zero-1729 commented at 10:03 AM on October 10, 2019: contributor

Yeah, fair enough. I'll open a PR as soon as I am done.

Thanks for the clarification 👍
Zero-1729 referenced this in commit 6cdb9560dc on Oct 10, 2019
Zero-1729 referenced this in commit 758ef6a9d3 on Oct 10, 2019
Zero-1729 referenced this in commit 1f5dc40b95 on Oct 10, 2019
Zero-1729 commented at 1:36 PM on October 10, 2019: contributor

I just opened the PR. 👍
Zero-1729 referenced this in commit 3c8834f85a on Oct 10, 2019
Zero-1729 referenced this in commit b5d6aceaae on Oct 16, 2019
Zero-1729 referenced this in commit 5c4a9a947c on Nov 24, 2019
Zero-1729 referenced this in commit 44f15cfdcf on Jan 6, 2020
jonasschnelli closed this on Jan 27, 2020
jonasschnelli referenced this in commit 3253b5dcf4 on Jan 27, 2020
sidhujag referenced this in commit 67ff110a92 on Jan 27, 2020
JeremyRubin referenced this in commit 3a84470ecc on Feb 7, 2020
HashUnlimited referenced this in commit ff859292be on Apr 17, 2020
sidhujag referenced this in commit 65ea373f78 on Nov 10, 2020
backpacker69 referenced this in commit f0f3dc6220 on Mar 28, 2021
DrahtBot locked this on Feb 15, 2022
Munkybooty referenced this in commit 1b6373b701 on Jun 25, 2022
Munkybooty referenced this in commit 4d41117ef1 on Aug 3, 2022
Munkybooty referenced this in commit 56864c40b6 on Aug 22, 2022
Munkybooty referenced this in commit 8a12e974de on Aug 24, 2022
Munkybooty referenced this in commit 4ab9adaa10 on Aug 31, 2022
Munkybooty referenced this in commit c6591d08fc on Sep 19, 2022
Munkybooty referenced this in commit 5a9bf180b0 on Oct 3, 2022

Contributors

Labels

Linked (view graph)

#17096 gui: rename debug window