Fixes #17019
Was initially part of #17044 but as the test got larger it made sense to split it into its own commit as suggested in #17019 .
This is testing the -loadblock option by using the scripts in contrib/linearize to generate a bootstrap.dat file and starting a disconnected node with it. So it is also testing the linearize scripts which were untested before and needed to be made available for the CI environment, hence they are added to DIST_CONTRIB in Makefile.am.
56+ linearize_dir = os.path.join(base_dir, "contrib", "linearize")
57+
58+ self.log.info("Run linearization of block hashes")
59+ linearize_hashes_path = os.path.join(linearize_dir, "linearize-hashes.py")
60+ hashes_args = [linearize_hashes_path, cfg_path, ">", hashlist_path]
61+ subprocess.run(" ".join(hashes_args), shell=True).check_returncode()
shell=True here? The immediate problem is that the arguments aren’t escaped, so this won’t work with paths with spaces, or other characters in it. You could escape the args with shlex.quote, but in general, it’s better to avoid the shell completely and use Python’s stdin/stdout/stderr redirection.
> is a shell feature. I could not find a different way to achieve it. In a normal case I would have used Pythons output redirect but I wanted to simulate the use of the scripts exactly as described in the script’s README. I guess one way to get rid of it would be to extend linearize-hashes.py to take an output parameter like linearize-data.py does. I could do this here or in a follow-up PR.
quote for now to make it more robust.
or directly redirect the output to a file
I am pretty sure we already do that in various places in our framework.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
make dist uses git archive by ch4ot1c)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.