Picking up some of the suggestions in the comments of #16727 including: #16727 (review) #16727 (review) #16727 (review)
refactor: Feebumper EstimateFeeRate follow-up #17098
pull adamjonas wants to merge 2 commits into bitcoin:master from adamjonas:16727-follow-up changing 4 files +50 −50-
adamjonas commented at 4:28 PM on October 10, 2019: member
-
typo and unneccessary parentheses 9be6666a4e
- fanquake added the label Refactoring on Oct 10, 2019
- fanquake added the label Wallet on Oct 10, 2019
-
MarcoFalke commented at 5:23 PM on October 10, 2019: member
ACK c4d8cc82608106a0518b86cdf855f0fa99164c0e
I don't really understand why we pass wallet pointers everywhere in this file, so you might also change the others if you feel like it. Though, I don't have a strong opinion.
- adamjonas force-pushed on Oct 10, 2019
-
change wallet pointers to references in feebumper 66b29848c7
- adamjonas force-pushed on Oct 10, 2019
-
DrahtBot commented at 1:06 AM on October 11, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #16910 (wallet: reduce loading time by using unordered maps by achow101)
- #16373 (Add bumpfee option to return PSBT instead of commiting to wallet by instagibbs)
- #15931 (Remove GetDepthInMainChain dependency on locked chain interface by ariard)
- #15921 (validation: Tidy up ValidationState interface by jnewbery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
promag commented at 7:08 AM on October 11, 2019: member
Code review ACK 66b29848c71c4b3b4dc36ca6d94de829bd533797.
-
MarcoFalke commented at 12:18 PM on October 11, 2019: member
ACK 66b29848c71c4b3b4dc36ca6d94de829bd533797 (looked at the diff on GitHub)
- MarcoFalke renamed this:
refactor: Feebumper EstimateFeeRate
refactor: Feebumper EstimateFeeRate follup-up fixes
on Oct 11, 2019 - adamjonas renamed this:
refactor: Feebumper EstimateFeeRate follup-up fixes
refactor: Feebumper EstimateFeeRate follow-up fixes
on Oct 11, 2019 -
laanwj commented at 7:31 AM on October 12, 2019: member
Concept ACK.
BTW: please don't use the word 'refactor' and 'fixes' in one title, it's useful to know from the title whether something is a refactor or bug-fix. It can't be both because a refactor, by definition, is intended to keep behavior exactly the same.
- MarcoFalke renamed this:
refactor: Feebumper EstimateFeeRate follow-up fixes
refactor: Feebumper EstimateFeeRate follow-up
on Oct 12, 2019 -
fjahr commented at 10:04 AM on October 15, 2019: member
ACK 66b2984 reviewed code
- MarcoFalke referenced this in commit e180be49d7 on Oct 15, 2019
- MarcoFalke merged this on Oct 15, 2019
- MarcoFalke closed this on Oct 15, 2019
- adamjonas deleted the branch on Oct 15, 2019
- sidhujag referenced this in commit 5b52c182ea on Oct 16, 2019
- MarkLTZ referenced this in commit 763e1c18b6 on Nov 17, 2019
- DrahtBot locked this on Dec 16, 2021
Labels