depends: Eliminate hard dependency on Ubuntu-ABI specific clang #17099

1. 
   dongcarl commented at 4:30 pm on October 10, 2019: member

   This is based on:

   1. #16392
   2. My fixes for #16392: https://github.com/fanquake/bitcoin/compare/329af88c548ff4afe6fed7fdbad3d39f62044048...dongcarl:2019-10-fixing-fanquake-osx-bump

   We previously just downloaded a clang binary from llvm.org. However, I think clang is mature and mainstream enough for us to use the system one. The Gitian descriptors have also been changed accordingly (and work).

   ---

   MarcoFalke if the Gitian Builds fail for this one, it’s because:

   We DO need to fix our docs for generating macOS SDKs… Previously we just tarred up MacOSX10.14.sdk, but we also need to copy over the headers as done here: https://github.com/tpoechtrager/osxcross/blob/d3392f4eae78f3fa3f1fd065fa423f2712825102/tools/gen_sdk_package.sh#L183-L188

   In fact, we should probably just subtree tpoechtrager’s SDK generation scripts.

2. dongcarl added the label Build system on Oct 10, 2019
3. fanquake added the label macOS on Oct 10, 2019
4. 
   laanwj commented at 6:16 pm on October 10, 2019: member

   We DO need to fix our docs for generating macOS SDKs… Previously we just tarred up MacOSX10.14.sdk, but we also need to copy over the headers as done here

   If you need people to re-generate the MacOSX SDK, please document it well and make sure there’s a way that people without Macs can do it (I don’t have access to a Mac anymore, for one). Might want to combine it with the version upgrade. Edit: oh, you did base it on #16392 already.

5. dongcarl force-pushed on Oct 15, 2019
6. depends: clang 6.0.1

   This also removes some now-unnecessary cctools hacks
   
   Co-Authored-By: Cory Fields <cory-nospam-@coryfields.com>

   70b0eacf99
7. build: set minimum supported macOS to 10.12 87f9413576
8. build: use macOS 10.14 SDK eb7d766dd5
9. depends: native_cctools 921, ld64 409.12, libtapi 1000.10.8

   This also removes the obsolete mlinker-version option
   
   Co-Authored-By: Cory Fields <cory-nospam-@coryfields.com>

   b052792719
10. depends: Eliminate dependency on ABI-specific clang

    For the longest time we have downloaded an Ubuntu ABI-specific clang and
    just used it. No longer will we be subject to the tyranny of Ubuntu's
    ABI!

    df10bed21a
11. scripted-diff: depends: Decouple toolchain + binutils

    We manually put the toolchain and binutils into the same path in
    native_cctools, this is unintuitive. Since we effectively decouple our
    toolchain and binutils in this patchset, the make variables should
    reflect this as well.
    
    The $(toolchain_path) prefix is removed in the next commit. They are
    separate so I can do this scripted-diff.
    
    -BEGIN VERIFY SCRIPT-
    find depends -type f -print0 | xargs -0 sed -i "s/_native_toolchain/_native_binutils/g"
    find depends -type f -print0 | xargs -0 sed -i "s/toolchain_path/binutils_path/g"
    -END VERIFY SCRIPT-

    b9c19e68c1
12. depends: No more binutils_path prefix for CC in site

    If we do end up building a compiler inside depends in the future, we can
    just add a separate compiler_path prefix and use it here.
    
    See the previous commit for more details.

    0d3f3428c9
13. contrib: macdeploy: Minor README changes. 1250d228e1
14. contrib: macdeploy: Correctly generate macOS SDK

    Previously, we did not include the libc++ headers in our SDK creation,
    now we can use tpoechtrager's script to correctly do that. The
    gen_sdk_package.sh is taken from
    https://github.com/tpoechtrager/osxcross/blob/d3392f4eae78f3fa3f1fd065fa423f2712825102/tools/gen_sdk_package.sh
    
    We also document this change.

    a0fefee822
15. dongcarl force-pushed on Oct 15, 2019
16. 
    dongcarl commented at 11:36 pm on October 15, 2019: member

    Updated documentation in 1250d228e14672e4c2e0c83a6548929749c64ce0 and a0fefee822f2bb3f8bcd7ba6a08eb6df9b5c5a35, would like some advice on whether it’s alright to just copy the script over from https://github.com/tpoechtrager/osxcross/blob/d3392f4eae78f3fa3f1fd065fa423f2712825102/tools/gen_sdk_package.sh in a0fefee822f2bb3f8bcd7ba6a08eb6df9b5c5a35
17. 
    DrahtBot commented at 2:34 am on October 16, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16392 (build: macOS toolchain update by fanquake)
    • #15441 ([doc] build: warn against spaces in working directory by Sjors)
    • #12557 ([WIP] 64 bit iOS device support by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

18. laanwj added this to the "PRs" column in a project

    ---

19. 
    MarcoFalke commented at 1:51 pm on November 19, 2019: member

    Is it really required to first bump clang to a more recent version and then in the next commit remove the hardcoded clang? Wouldn’t it be more straightforward to just remove the hardcoded clang?
20. dongcarl force-pushed on Dec 17, 2019
21. dongcarl force-pushed on Dec 19, 2019
22. dongcarl force-pushed on Jan 13, 2020
23. dongcarl closed this on Jul 9, 2020

    ---

24. fanquake referenced this in commit 1148f3d630 on Jul 16, 2020
25. sidhujag referenced this in commit 33369338f9 on Jul 18, 2020
26. fanquake moved this from the "PRs" to the "Done" column in a project

    ---

27. DrahtBot locked this on Feb 15, 2022

Contributors
dongcarl laanwj DrahtBot MarcoFalke

Labels
macOS Build system