ch4ot1c
commented at 10:37 pm on October 10, 2019:
contributor
Changes make dist to use git archive instead of its default approach ,EXTRA_DIST.
The clientversion.cpp version suffix is set to the commit hash of HEAD. There are additional files that are appended beyond this, namely configure and other autotools generated files. The .git directory is not included. Target dist: is used without a dist-hook:.
0./autogen.sh && ./configure && make dist
Lastly, simplifies the layout of Makefile.am.
Note - MacOS would need gtar to use tar --transform for appending the autotools generated files in a prefixed way (an alternate approach). This PR uses git add -f instead.
luke-jr
commented at 10:39 pm on October 10, 2019:
member
Concept ACK, but the distfile needs to include autogen-generated files.
And I don’t see why it should be running submodules’ make dists…
fanquake added the label
Build system
on Oct 10, 2019
ch4ot1c
commented at 11:00 pm on October 10, 2019:
contributor
I agree, for GNU conformance and support for exotic systems.
Moved the univalue issue+pr to its upstream repo.
DrahtBot
commented at 1:04 am on October 11, 2019:
member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#17091 (tests: Add test for loadblock option and linearize scripts by fjahr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label
Needs rebase
on Oct 11, 2019
ch4ot1c force-pushed
on Oct 20, 2019
ch4ot1c force-pushed
on Oct 20, 2019
build: Simplify Makefile.am
- Remove `EXTRA_DIST` entries
- Delineate MacOS and Windows sections
- Use `WIN_` prefix consistently
dc504f2367
build: Add distdir / extracted archive to .gitignorec261bd5122
ch4ot1c force-pushed
on Oct 20, 2019
build: `make dist` uses `git archive`
Keeps its behavior:
- Sets version in src/clientversion.cpp to HEAD commit
- Adds autotools-generated files like `configure`
6e7ef967ab
ch4ot1c force-pushed
on Oct 20, 2019
DrahtBot removed the label
Needs rebase
on Oct 20, 2019
ch4ot1c renamed this:
[WIP] build: `make dist` uses `git archive`
build: `make dist` uses `git archive`
on Oct 20, 2019
build: Remove phony dist, formatting3ee34aeb0c
build: Use abs_top_srcdir to find genbuild.sh91d8c9e7cb
build: Use abs_top_builddir to find genbuild.shc4703c2212
DrahtBot
commented at 10:48 am on October 23, 2019:
member
DrahtBot added the label
Needs rebase
on Oct 23, 2019
laanwj added this to the milestone 0.20.0
on Nov 18, 2019
laanwj
commented at 1:27 pm on November 18, 2019:
member
Would be nice to have this in 0.20.0.
hebasto
commented at 11:29 am on March 10, 2020:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-12-19 03:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me