build: make dist uses git archive #17104

1. 
   ch4ot1c commented at 10:37 pm on October 10, 2019: contributor

   Changes make dist to use git archive instead of its default approach ,EXTRA_DIST.

   The clientversion.cpp version suffix is set to the commit hash of HEAD. There are additional files that are appended beyond this, namely configure and other autotools generated files. The .git directory is not included. Target dist: is used without a dist-hook:.

   0./autogen.sh && ./configure && make dist
   

   Lastly, simplifies the layout of Makefile.am.

   Note - MacOS would need gtar to use tar --transform for appending the autotools generated files in a prefixed way (an alternate approach). This PR uses git add -f instead.

2. 
   luke-jr commented at 10:39 pm on October 10, 2019: member

   Concept ACK, but the distfile needs to include autogen-generated files.

   And I don’t see why it should be running submodules’ make dists…

3. fanquake added the label Build system on Oct 10, 2019
4. 
   ch4ot1c commented at 11:00 pm on October 10, 2019: contributor

   I agree, for GNU conformance and support for exotic systems.

   Moved the univalue issue+pr to its upstream repo.

5. 
   DrahtBot commented at 1:04 am on October 11, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17091 (tests: Add test for loadblock option and linearize scripts by fjahr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. DrahtBot added the label Needs rebase on Oct 11, 2019
7. ch4ot1c force-pushed on Oct 20, 2019
8. ch4ot1c force-pushed on Oct 20, 2019
9. build: Simplify Makefile.am

   - Remove `EXTRA_DIST` entries
   - Delineate MacOS and Windows sections
   - Use `WIN_` prefix consistently

   dc504f2367
10. build: Add distdir / extracted archive to .gitignore c261bd5122
11. ch4ot1c force-pushed on Oct 20, 2019
12. build: `make dist` uses `git archive`

    Keeps its behavior:
    
    - Sets version in src/clientversion.cpp to HEAD commit
    - Adds autotools-generated files like `configure`

    6e7ef967ab
13. ch4ot1c force-pushed on Oct 20, 2019
14. DrahtBot removed the label Needs rebase on Oct 20, 2019
15. ch4ot1c renamed this:
    [WIP] build: `make dist` uses `git archive`
    build: `make dist` uses `git archive`
    on Oct 20, 2019
16. build: Remove phony dist, formatting 3ee34aeb0c
17. build: Use abs_top_srcdir to find genbuild.sh 91d8c9e7cb
18. build: Use abs_top_builddir to find genbuild.sh c4703c2212
19. 
    DrahtBot commented at 10:48 am on October 23, 2019: member
20. DrahtBot added the label Needs rebase on Oct 23, 2019
21. laanwj added this to the milestone 0.20.0 on Nov 18, 2019
22. 
    laanwj commented at 1:27 pm on November 18, 2019: member

    Would be nice to have this in 0.20.0.
23. 
    hebasto commented at 11:29 am on March 10, 2020: member

    @ch4ot1c Are you still working on this?
24. laanwj added the label Up for grabs on Mar 11, 2020
25. 
    laanwj commented at 5:46 pm on March 11, 2020: member

    Labeling this “up for grabs”. It’d be nice to have this for 0.20.
26. fanquake removed the label Needs rebase on Mar 12, 2020
27. fanquake removed the label Up for grabs on Mar 12, 2020
28. fanquake closed this on Mar 12, 2020

    ---

29. fanquake removed this from the milestone 0.20.0 on Mar 12, 2020
30. laanwj referenced this in commit baa72cd9a2 on Mar 25, 2020
31. sidhujag referenced this in commit 56ca0913fc on Mar 28, 2020
32. UdjinM6 referenced this in commit 98417ecad2 on Oct 23, 2021
33. UdjinM6 referenced this in commit 9e85411dc7 on Oct 23, 2021
34. UdjinM6 referenced this in commit 83cbc3c811 on Dec 4, 2021
35. DrahtBot locked this on Feb 15, 2022

Contributors
ch4ot1c luke-jr DrahtBot laanwj hebasto

Labels
Build system