doc: Fix broken bitcoin-cli examples #17119

pull andrewtoth wants to merge 1 commits into bitcoin:master from andrewtoth:example-fixes changing 1 files +3 −3

andrewtoth commented at 8:55 PM on October 12, 2019: contributor

This fixes the bitcoin-cli examples for combinerawtransaction, combinepsbt and testmempoolaccept. They currently return Error parsing JSON.
fanquake added the label Docs on Oct 12, 2019
fanquake added the label RPC/REST/ZMQ on Oct 12, 2019
fanquake renamed this:
~~[rpc] Fix broken bitcoin-cli examples~~
rpc: Fix broken bitcoin-cli examples
on Oct 12, 2019
kristapsk approved
kristapsk commented at 10:10 PM on October 12, 2019: contributor

ACK e71cc9086481fd7a62df96296ee2baeb43e06ed0, tested having / not having JSON decode errors for examples given before / after.
fjahr commented at 4:33 PM on October 13, 2019: contributor

Concept ACK

I did a quick grep and I think combinepsbt has the same issue so you could add it.
andrewtoth force-pushed on Oct 13, 2019
andrewtoth commented at 5:10 PM on October 13, 2019: contributor

@fjahr Ahh I missed that one. Updated.
andrewtoth renamed this:
~~rpc: Fix broken bitcoin-cli examples~~
doc: Fix broken bitcoin-cli examples
on Oct 13, 2019

in src/rpc/rawtransaction.cpp:613 in 57fb1c7611 outdated

 609 | @@ -610,7 +610,7 @@ static UniValue combinerawtransaction(const JSONRPCRequest& request)
 610 |              "\"hex\"            (string) The hex-encoded raw transaction with signature(s)\n"
 611 |                  },
 612 |                  RPCExamples{
 613 | -                    HelpExampleCli("combinerawtransaction", "[\"myhex1\", \"myhex2\", \"myhex3\"]")
 614 | +                    HelpExampleCli("combinerawtransaction", "\"[\\\"myhex1\\\", \\\"myhex2\\\", \\\"myhex3\\\"]\"")

laanwj commented at 8:29 AM on October 14, 2019:

why not use single quotes here? that'd avoid having to escape the inner "'s (also using a C++11 raw string literal R"(…)" could potentially make this more readable)

andrewtoth commented at 5:10 PM on October 14, 2019:

Done.

[rpc] Fix broken bitcoin-cli examples 85016e52f6
andrewtoth force-pushed on Oct 14, 2019
laanwj commented at 1:38 PM on October 17, 2019: member

ACK 85016e52f6adc01735beefe5a8aefcc4f0c4aa25
laanwj referenced this in commit 048e456fc4 on Oct 17, 2019
laanwj merged this on Oct 17, 2019
laanwj closed this on Oct 17, 2019
sidhujag referenced this in commit a0728ff84c on Oct 18, 2019
MarkLTZ referenced this in commit 8823f65197 on Apr 7, 2020
MarkLTZ referenced this in commit 0a1571d657 on Apr 7, 2020
deadalnix referenced this in commit 873376c951 on Aug 24, 2021
bitcoin locked this on Dec 16, 2021
andrewtoth deleted the branch on Aug 17, 2023

Contributors

Labels