This commit removes 2 shortcuts which are now unnecessary (see new shortcuts which were introduced in 091747b). Also removes some related unnecessary code.
gui: remove unnecessary shortcuts in bitcoingui files #17128
pull GChuf wants to merge 1 commits into bitcoin:master from GChuf:clean-bitcoingui changing 2 files +0 −9-
GChuf commented at 8:19 PM on October 13, 2019: contributor
- fanquake added the label GUI on Oct 13, 2019
-
hebasto commented at 8:41 PM on October 13, 2019: member
Concept ACK.
Indeed, Ctrl+Shift+C is replaced by Ctrl+T. But the Ctrl+Shift+D shortcut is still quite useful, IMO.
-
DrahtBot commented at 8:42 PM on October 13, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
-
laanwj commented at 9:51 AM on October 14, 2019: member
FWIW: please try to use PR and commit titles that describe your change more precisely. "gui: clean bitcoingui files" doesn't convey much information.
- GChuf renamed this:
gui: clean bitcoingui files
gui: remove unnecessary shortcut in bitcoingui files …
on Oct 15, 2019 -
GChuf commented at 8:16 AM on October 15, 2019: contributor
Renamed, hopefully the title is clearer now.
- GChuf renamed this:
gui: remove unnecessary shortcut in bitcoingui files …
gui: remove unnecessary shortcuts in bitcoingui files
on Oct 15, 2019 - fanquake requested review from jonasschnelli on Oct 15, 2019
- DrahtBot added the label Needs rebase on Oct 15, 2019
-
laanwj commented at 10:03 AM on October 16, 2019: member
Renamed, hopefully the title is clearer now.
Yes, thanks!
- DrahtBot removed the label Needs rebase on Oct 23, 2019
-
GChuf commented at 2:51 PM on October 30, 2019: contributor
Squashed and decided to keep the
showDebugWindowshortcut as per hebasto's opinion. -
f0fbb0d3af
gui: remove unnecessary shortcuts in bitcoingui files
Cleans unnecessary code after shortcuts were added in 091747b
- hebasto approved
-
hebasto commented at 5:30 PM on October 31, 2019: member
ACK f0fbb0d3af8ae0589df2db35d66b9dee47ba734f, tested on Linux Mint 19.2:
Ctrl+Shift+C- does nothingCtrl+{I|T|N|P}- behavior is unchanged
-
luke-jr commented at 2:53 PM on November 4, 2019: member
Concept NACK: Unless there's a reason to, we shouldn't break existing shortcuts...
-
-
luke-jr commented at 5:30 PM on November 4, 2019: member
I see no reasons given. An additional shortcut key does not in any way justify removal of the existing one.
-
jonasschnelli commented at 7:45 PM on November 4, 2019: contributor
Tend to NACK. IMO there is no harm in keeping the "old" one (and I expect there are users using this shortcut heavily).
- jonasschnelli removed review request from jonasschnelli on Nov 4, 2019
- fanquake closed this on Nov 4, 2019
- DrahtBot locked this on Feb 15, 2022
