Always display TX fee in dialog

iancoleman commented at 0:16 am on August 24, 2012: none

The client dialog for sending a transaction currently only displays the amount to be transferred and not the amount for the fee. The dialog should always show the fee.

See https://github.com/thedawnrider/malicious-bitcoin-example and https://bitcointalk.org/index.php?topic=102606

Current dialog: http://i.imgur.com/s6d9Y.png

Suggested dialog: http://i.imgur.com/AvMOy.png

Diapolo commented at 8:55 am on August 24, 2012: none

Good catch!

laanwj commented at 8:58 am on August 24, 2012: member

Yes that would be useful

laanwj commented at 9:54 am on August 24, 2012: member

It’s pretty trivial to make it show the preferred fee (as set in Options). Maybe that’s good enough.

However, showing the computed fee, which is only available after building the transaction, would require quite some re-ordering and re-thinking.

Currently the order of operating when the send button is clicked is:

Build list of recipients / amounts from UI
Show confirmation dialog
Ask passphrase to unlock encrypted wallet
WalletModel::sendCoins
- Do input checks (balance, duplicates, empties etc)
- With wallet mutex
  - Build transaction outputs
  - Create transaction -> determines inputs for outputs, this returns the computed fee nFeeRequired
  - Callback: If the computed fee is higher than the configured fee, ask user if he accepts the fee
  - Commit transaction (send to network)
- Update misc stuff (labels, addresses)

So that would effectively mean that the confirmation can only be shown after the transaction has been created, probably by splitting send into a two-stage process.

Diapolo commented at 10:37 am on August 24, 2012: none

A re-ordering would be nice, as that perhaps also solves the issue with not knowing how high the fee will be (#1570)! But a 2-stage fix is fine with me :).

laanwj commented at 9:23 am on August 25, 2012: member

Yes I think that’d also be best. The user knows what fee he has configured, so the first proposal is kind of pointless.

Showing the computed fee could even give the user the chance to to pay more or less. Of course, paying less could mean that miners don’t include the fee, but that’s the user’s own risk.

shamoons commented at 4:30 pm on September 17, 2012: none

I want to get involved with bitcoin development. Think this would be a decent thing for me to work on?

laanwj commented at 5:15 pm on September 17, 2012: member

I don’t think this is an good issue to start with. This cross-cuts into both the UI and core code, and touches code that is pretty risky to alter.

Of course, you can always try…

shamoons commented at 6:45 pm on September 17, 2012: none

Any recommendations on a good issue then? On Sep 17, 2012 1:15 PM, “Wladimir J. van der Laan” < notifications@github.com> wrote:

I don’t think this is an good issue to start with. This cross-cuts into both the UI and core code, and touches code that is pretty risky to alter.

Of course, you can always try…

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/issues/1714#issuecomment-8622952.

laanwj commented at 8:21 am on September 18, 2012: member

Improving the transaction details dialog would be a nice one. It could be user friendlier, looks like abracadabra currently to normal users, and also has some problems such as #1725 and #752.

ghost assigned laanwj on Sep 21, 2012

qubez commented at 2:54 pm on October 23, 2012: none

It seems impossible to lock down the voluntary tx fee, a trojan simply writing a new paytxfee to the user’s conf file could cause some unnoticed higgledy-piggledy. It would be wise to deprecate the config file setting and move tx fee inside the encrypted wallet. In addition the voluntary fee should be shown with a confirmation box whenever it is non-zero.

Belkaar commented at 8:11 am on February 13, 2013: none

Please make the wording in the dialog more clear so that the user understands that the fee is paid additionally to the amount he sends and not included. I frequently get people sending a fee-amount too much on my website because they seem to think that the fee will be deducted at the recipients end. (Thanks paypal I guess)

qubez commented at 11:04 am on April 9, 2013: none

Just going to drop this here from #2403: This needs to get coded as optional fees become normal and users need to know what they are sending (especially so they can rethink if their fee is OptionalFee x kB of spam). Optional fees give no warning currently.

transfeesimple

Diapolo commented at 12:39 pm on April 9, 2013: none

@qubez So you don’t have a patch, but just did some graphics mod how you would like it to look ;)?

qubez commented at 5:37 pm on April 9, 2013: none

Funny how two semesters of writing bubble sorts in Java doesn’t prepare you to grok Bitcoin written in a language and framework you’ve never used… ;)

Diapolo commented at 11:26 am on September 17, 2013: none

@laanwj Can be closed, as the great patch from @jonasschnelli was merged recently.

Diapolo commented at 8:54 am on October 4, 2013: none

Can still be closed… dear devs, please help ^^.

gavinandresen closed this on Oct 4, 2013

suprnurd referenced this in commit 8591448094 on Dec 5, 2017

MarcoFalke locked this on Sep 8, 2021

Always display TX fee in dialog #1714