test: Fix bug in blockfilter_index_tests. #17140

pull jimpo wants to merge 1 commits into bitcoin:master from jimpo:fix-index-test changing 1 files +14 −6
  1. jimpo commented at 8:07 pm on October 14, 2019: contributor

    The test case tests a chain reorganization, however the two chains were generated in the same manner and thus produced the same blocks.

    This issue was pointed out by MarcoFalke.

  2. test: Fix bug in blockfilter_index_tests.
    The test case tests a chain reorganization, however the two
    chains were generated in the same manner and thus produced
    the same blocks.
    f59bbb61af
  3. fanquake added the label Tests on Oct 14, 2019
  4. fanquake requested review from MarcoFalke on Oct 14, 2019
  5. MarcoFalke commented at 9:57 pm on October 14, 2019: member
    Thanks! ACK f59bbb61af5055844c16939a4f8e58c4f73843c1 (looked at the diff on GitHub, didn’t compile, nor run tests)
  6. DrahtBot commented at 10:57 pm on October 14, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16279 (Return the AcceptBlock CValidationState directly in ProcessNewBlock by TheBlueMatt)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. MarcoFalke referenced this in commit 4f42284fc0 on Oct 17, 2019
  8. MarcoFalke merged this on Oct 17, 2019
  9. MarcoFalke closed this on Oct 17, 2019

  10. sidhujag referenced this in commit 3def055b00 on Oct 18, 2019
  11. MarkLTZ referenced this in commit 543a72e592 on Nov 17, 2019
  12. deadalnix referenced this in commit 0185bdc9df on Jun 11, 2020
  13. MarcoFalke locked this on Dec 16, 2021


jimpo MarcoFalke DrahtBot


MarcoFalke

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me