test: Rename SegwitVersion1SignatureHash() #17141

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2019-10-segwit-v1-is-segwit-v0 changing 3 files +12 −12

jnewbery commented at 9:13 PM on October 14, 2019: member

The function implementing segwit v0 signature hash was originally named SegwitVersion1SignatureHash() (presumably before segwit v0 was named segwit v0). Rename it to SegwitV0SignatureHash().

Also rename SignatureHash() to LegacySignatureHash() for disambiguation.

[test] rename SegwitVersion1SignatureHash()

The function implementing segwit v0 signature hash was originally named
SegwitVersion1SignatureHash() (presumably before segwit v0 was named
segwit v0). Rename it to SegwitV0SignatureHash().

Also rename SignatureHash() to LegacySignatureHash() for disambiguation.

eebcdfa86a

fanquake added the label Tests on Oct 14, 2019
laanwj commented at 6:22 AM on October 15, 2019: member

ACK eebcdfa86a3dad4969fa9994614bcb446849ed2b
elichai commented at 10:29 AM on October 15, 2019: contributor

ACK eebcdfa86a3dad4969fa9994614bcb446849ed2b (Checked to see you didn't miss any renaming)
theStack commented at 10:49 AM on October 15, 2019: member

ACK https://github.com/bitcoin/bitcoin/commit/eebcdfa86a3dad4969fa9994614bcb446849ed2b
fanquake renamed this:
~~Test: Rename SegwitVersion1SignatureHash()~~
test: Rename SegwitVersion1SignatureHash()
on Oct 15, 2019
fanquake referenced this in commit 029c65e04c on Oct 15, 2019
fanquake merged this on Oct 15, 2019
fanquake closed this on Oct 15, 2019
jnewbery deleted the branch on Oct 15, 2019
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels