TX Fee can be set to anything by anyone #1715

issue iancoleman opened this issue on August 24, 2012
  1. iancoleman commented at 12:18 AM on August 24, 2012: none

    The transaction fee can be set to any value by any person. This may lead to the user sending a small amount of coins and accidentally paying a giant tx fee without ever realising it.

    See https://github.com/thedawnrider/malicious-bitcoin-example for an example of how this is done.

    Options for resolving this are outlined here https://bitcointalk.org/index.php?topic=102606.msg1126479#msg1126479

  2. hllhll commented at 9:49 PM on March 12, 2013: none

    If this is a trojan horse of some kind, malware, or any kind of malicious EXE, What is the problem for the torjan to replace all the Bitcoin-QT software altogether, maybe even leaking out private keys...

  3. jonasschnelli commented at 10:27 AM on May 3, 2013: contributor

    Should we display the txfee in the transcation-confirm-promt in bitcoin-qt? Display the txfee only when it's higher than the tx amount?

    Protection (some security mechanism) of the config/registry value would make no sense in my eyes.

  4. laanwj commented at 12:14 PM on May 3, 2013: member

    Not sure, it would be nice to do so, but I don't think the actual fee is known yet at the time the confirmation dialog is shown (that's also why there is an separate askFee prompt).

  5. jonasschnelli commented at 2:52 PM on May 3, 2013: contributor

    @laanwj could we not just show the "nTransactionFee" from walletmodel in the dialog according to mockups in #1714? Because we also do the exceeds calculations based on nTransactionFee,... so i would say it's also okay to place them there. The real txfee will might be different. Maybe we show " and ~0.0005 BTC to transaction fees"?

  6. laanwj commented at 4:10 PM on May 3, 2013: member

    Nah, showing an approximate value could confuse people even more. I'm for either showing nothing or the actual fee that will be paid.

  7. jonasschnelli commented at 7:36 AM on May 6, 2013: contributor

    @laanwj okay,... let me check if i can somehow calculate (use the current txfee calc code) the fee before the confirmation dialogue pops up.

  8. laanwj commented at 12:11 PM on November 7, 2013: member

    This is fixed by #2651, closing

  9. laanwj closed this on Nov 7, 2013

  10. suprnurd referenced this in commit ec8178c40a on Dec 5, 2017
  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 12:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me