Qt: show mined transactions at depth 1 #1717

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_change_TX_display changing 2 files +3 −13

Diapolo commented at 6:25 AM on August 24, 2012: none
- before, we used to show them in GUI when depth >= 2, which could lead to confusion of users, as the RPC behaviour already showed the Tx
Related to #1712.

Qt: show mined transactions at depth 1

- before, we used to show them in GUI when depth >= 2, which could lead to
  confusion of users, as the RPC behaviour already showed the Tx

f09e8fcd33

in src/qt/transactionrecord.cpp:None in f51af2c9c3 outdated
```
  27 | -        }
  28 | +        // Shows generated coins / mined transactions at depth 1
  29 | +        return true;
  30 |      }
  31 | -    return true;
  32 | +    return false;
```
luke-jr commented at 6:46 AM on August 24, 2012:

Why is this inverted? Won't it hide all non-coinbase txns? O.o

Diapolo commented at 6:48 AM on August 24, 2012:

Seems like I edited something that was wrong, sorry for that ... will fix this.
laanwj commented at 10:26 AM on August 24, 2012: member

Hopefully people won't start crying that their transaction disappeared and such when their branch is orphaned...
Diapolo commented at 10:33 AM on August 24, 2012: none

@laanwj IMHO we can't protect people from everything and should not special case too much (and that I learned from you ^^).
laanwj commented at 8:29 AM on August 25, 2012: member

Yes, I was just playing devil's advocate. We don't have the 'immature' balance for nothing, it means that the mined transaction is not yet set in stone.

ACK
BitcoinPullTester commented at 11:02 PM on August 25, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f09e8fcd33f7f1b1f4e20f2148bbf919b97db0c4 for binaries and test log.
laanwj referenced this in commit bfc24bd4ce on Sep 20, 2012
laanwj merged this on Sep 20, 2012
laanwj closed this on Sep 20, 2012
owlhooter referenced this in commit 3bffd1bc62 on Oct 10, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#1712 Qt: possible bug related to immature balance?