bench: Add BIP 143 sighash benchmark #17175

1. 
   maflcko commented at 1:52 pm on October 17, 2019: member

   I believe there is no benchmark for the BIP 143 signature hash. Just for completeness, it would be nice to have a few different sighash flags benchmarked.
2. maflcko added the label Feature on Oct 17, 2019
3. maflcko added the label Tests on Oct 17, 2019
4. 
   maflcko commented at 2:08 pm on October 17, 2019: member

   Maybe even combine it with a benchmark of CheckInputScripts (renamed in #16658)?
5. 
   theStack commented at 9:41 pm on October 25, 2019: contributor

   Would it make sense to include an extreme transaction with lots of inputs (similar to this: https://www.blockchain.com/btc/tx/bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08 further explanation here: http://rusty.ozlabs.org/?p=522) for this benchmark, to compare legacy vs BIP 143 signature hash performance? Though I can hardly imagine that it was not done in the course of the introduction of BIP 143, as runtime reduction from O(n²) to O(n) was one of the main points of this. Or is this indirectly tested with some other benchmarks? If yes, what’s the point of having separate benchmarks focussing on solely the signature hash? Just asking all this from the perspective of a newbie.
6. 
   kevkevinpal commented at 11:43 pm on March 26, 2024: contributor

   I added a benchmark for CheckInputScripts I have not worked on benchmarks before so please let me know if this commit looks good f9e0dfc

Contributors
maflcko theStack kevkevinpal

Labels
Feature Tests