0.19: Revert 14193 to fix 17112 #17182

1. 
   promag commented at 11:07 PM on October 17, 2019: member

   Partially reverts #14193 to fix #17112. This is the safest approach for 0.19 compared to #17135.

2. wip: Revert fa2b083c3feb0522baf652045efa6b73458761a3 3df6b3100f
3. wip: Revert fabeb1f613653a8c1560e4a093a9b6b7a069b60b 0ba85fc1c7
4. fanquake added this to the milestone 0.19.0 on Oct 17, 2019
5. fanquake added the label Needs gitian build on Oct 17, 2019
6. wip: Drop annotations to fix build 14efdc9830
7. 
   MarcoFalke commented at 12:53 PM on October 18, 2019: member

   While reverting this should be conceptually fine, as the mempool bug can only be observed when polling the RPC and reorging the chain, this is no longer a clean git revert. Thus, I wonder why we prefer to potentially introduce a bug in bitcoind to avoid a fix in the GUI code.

   If #17135 brings down the frequency of the "not responding" pop ups to a 0.18.0 level, it should be preferred, imo.

8. 
   MarcoFalke commented at 12:54 PM on October 18, 2019: member

   I think DrahtBot filters pull requests for branch==master

9. 
   promag commented at 1:51 PM on October 18, 2019: member

   Clean revert is not possible. I tend to agree with Marco.

10. 
    laanwj commented at 11:06 AM on October 23, 2019: member

    If #17135 brings down the frequency of the "not responding" pop ups to a 0.18.0 level, it should be preferred, imo.

    Yes, to be honest both solutions are too involved for between RCs. I think we should just skip this for 0.19.0, leave fixing this properly for 0.19.1.

11. 
    promag commented at 11:09 AM on October 23, 2019: member

    Well at least I'm not comfortable with this one.

12. promag closed this on Oct 23, 2019

    ---

13. promag deleted the branch on Oct 23, 2019
14. MarcoFalke removed the label Needs gitian build on Nov 22, 2019
15. DrahtBot locked this on Dec 16, 2021

Milestone
0.19.0