Replace #16578 with a more specific solution #17187

issue laanwj opened this issue on October 18, 2019
  1. laanwj commented at 8:50 AM on October 18, 2019: member

    The change in #16578, although necessary, was over-sweeping.

    I was initially in favor of it, but never expected this. It is turning into a boondoggle, with repercussions from our testing process (#17013) to MacOS user experience (#17025, #17179). Even changes outside the GUI code itself (#17184). I feel this is getting out of hand. It creates a lot of work and we'll end up reverting all of this eventually.

  2. laanwj added the label GUI on Oct 18, 2019
  3. MarcoFalke added the label Brainstorming on Oct 18, 2019
  4. promag commented at 7:44 PM on October 18, 2019: member

    Perhaps there won't be more surprises? Otherwise I agree, we could revert and then blacklist some arguments instead.

  5. laanwj commented at 1:14 AM on October 19, 2019: member

    There is not even a need to blacklist any arguments.

    I mean, it's only a potential problem for one specific OS, in one specific use of the executable. MacOS shouldn't even have to be affected by this.

    In any case we're not going to add custom Objective C code for argument parsing on MacOS or something to work around this, that would be total madness.

  6. promag commented at 1:59 PM on October 19, 2019: member

    Another consequence was #17031.

  7. hebasto commented at 8:19 AM on October 3, 2021: member

    Considering #16578 (comment) is this still an issue?

  8. laanwj closed this on Apr 14, 2022

  9. DrahtBot locked this on Apr 14, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me