gui: send amount placeholder value #17195

1. 
   JeremyCrookshank commented at 10:31 PM on October 18, 2019: contributor

   Noticed that there wasn't a default value for the send amount. However if you put a value in or click the up and down arrows you're unable to get it blank again, so it makes sense that it has a default value. I hope this also makes it more clear that users can send less than 1 BTC if it shows the 8 decimal places

   PR:

2. 
   emilengler commented at 10:49 PM on October 18, 2019: contributor

   Concept ACK

3. fanquake added the label GUI on Oct 18, 2019
4. 
   laanwj commented at 1:31 AM on October 19, 2019: member

   NACK. I prefer the blank field, as it allows for pasting amounts (which is very common when doing currency conversions and such, or to paste the exact amount from orders).

5. 
   laanwj commented at 1:33 AM on October 19, 2019: member

   Maybe use setPlaceholderText? (though be careful: the number of decimals would depend on the configured unit)

6. fanquake added the label Waiting for author on Oct 19, 2019
7. 
   kristapsk commented at 11:38 AM on October 19, 2019: contributor

   I agree with @laanwj here.

8. JeremyCrookshank closed this on Oct 19, 2019

   ---

9. JeremyCrookshank force-pushed on Oct 19, 2019
10. Send amount shows minimum amount placeholder 57e2edea0b
11. JeremyCrookshank reopened this on Oct 19, 2019

    ---

12. 
    JeremyCrookshank commented at 12:48 PM on October 19, 2019: contributor

    I've attempted that now. Hope it's okay!

    PR:

13. JeremyCrookshank renamed this:
    gui: a default send amount value
    gui: send amount placeholder value
    on Oct 19, 2019
14. 
    promag commented at 1:56 PM on October 19, 2019: member

    ACK 57e2edea0bfea664e3f12dad2508139eb7f461bc.

15. fanquake removed the label Waiting for author on Oct 19, 2019
16. 
    Danny-Scott commented at 2:34 PM on October 19, 2019: contributor

    ACK - placeholder text makes complete sense here.

17. fanquake requested review from laanwj on Oct 19, 2019
18. 
    emilengler commented at 3:33 PM on October 19, 2019: contributor

    @laanwj You just need to do one click more to select the whole text and then you can just replace it (at least on most systems).

19. 
    GChuf commented at 9:06 AM on October 20, 2019: contributor

    ACK 57e2edea0bfea664e3f12dad2508139eb7f461bc

20. 
    laanwj commented at 10:28 AM on October 21, 2019: member

    ACK 57e2edea0bfea664e3f12dad2508139eb7f461bc, this is a surprisingly compact solution too

    @laanwj You just need to do one click more to select the whole text and then you can just replace it (at least on most systems).

    quick, patent Only One More Click :tm: payments

21. laanwj referenced this in commit a75cb122ed on Oct 21, 2019
22. laanwj merged this on Oct 21, 2019
23. laanwj closed this on Oct 21, 2019

    ---

24. 
    luke-jr commented at 4:18 PM on November 4, 2019: member

    @laanwj You just need to do one click more to select the whole text and then you can just replace it (at least on most systems).

    Pasting an amount to an empty field is a single middle click, nothing more.

    Replacing text would be a double-click (maybe triple on some systems?), then Ctrl-V on the keyboard. Significantly more complicated.

25. luke-jr referenced this in commit 5704c12512 on Nov 15, 2019
26. MarkLTZ referenced this in commit 1199dce669 on Nov 17, 2019
27. jasonbcox referenced this in commit 16d7b5f661 on Oct 30, 2020
28. MarcoFalke locked this on Dec 16, 2021

Contributors

JeremyCrookshankemilenglerlaanwjkristapskpromagDanny-ScottGChufluke-jr

Review Requested
laanwj