Noticed that getDisplayUnit() was being called 3 times but can be made more efficient if we store the value on the function once as a variable for reuse instead
refactor: call getDisplayUnit() once instead of three times #17221
pull JeremyCrookshank wants to merge 2 commits into bitcoin:master from JeremyCrookshank:sendcoincodereuse changing 1 files +4 −3-
JeremyCrookshank commented at 8:30 PM on October 22, 2019: contributor
-
reuse a variable instead of function a1373922de
- fanquake added the label GUI on Oct 22, 2019
- fanquake added the label Refactoring on Oct 22, 2019
-
promag commented at 8:35 PM on October 22, 2019: member
NACK, note the implementation: https://github.com/bitcoin/bitcoin/blob/9dd6bbba613d7462afdb6276c4002bc183478528/src/qt/optionsmodel.h#L74
-
removed word 9f285c5d95
- JeremyCrookshank closed this on Oct 22, 2019
- JeremyCrookshank deleted the branch on Oct 22, 2019
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels