doc: Change apt-get to apt #17256

1. 
   emilengler commented at 5:08 PM on October 25, 2019: contributor

   As all major dpkg distributions now support apt, and all who doesn't reached EOL, it would be better to switch to apt instead of the legacy apt-get.

   I haven't modified testing scripts because they might need apt-get because apt is not available there.

   If you don't now the difference, here is a short article which explains it.

2. doc: Change apt-get to apt b28c14bfd4
3. fanquake added the label Docs on Oct 25, 2019
4. 
   MarcoFalke commented at 6:43 PM on October 25, 2019: member

   NACK.

   apt-get isn't legacy. In fact it is probably the only thing that works in scripts. See

   # apt update |cat
   
   WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
   

5. fanquake requested review from laanwj on Oct 25, 2019
6. 
   DrahtBot commented at 8:34 PM on October 25, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17165 (Remove BIP70 support by fanquake)
   • #17099 (depends: Eliminate hard dependency on Ubuntu-ABI specific clang by dongcarl)
   • #16392 (build: macOS toolchain update by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   emilengler commented at 8:52 PM on October 25, 2019: contributor

   @MarcoFalke I did not modified scripts, only documentation.

8. 
   MarcoFalke commented at 9:07 PM on October 25, 2019: member

   Yes, but the documentation serves also as a source for scripts. I think the hassle to ask everyone to change the line manually when copy-pasting into a script is too much to ask. I don't see the advantage of apt over apt-get.

   Also, this conflicts with a bunch of other pull requests like #17165 (Remove BIP70 support by fanquake), which I'd rather not put into rebase hell again.

9. emilengler closed this on Oct 25, 2019

   ---

10. emilengler deleted the branch on Oct 25, 2019
11. 
    laanwj commented at 9:33 AM on October 26, 2019: member

    I always use apt as well. But agree this is not a necessary change. It's not bitcoin core's scope to teach people about what are user friendly commands to use, and apt-getworks just as well (and isn't going to be deprecated).

12. MarcoFalke locked this on Dec 16, 2021

Review Requested
laanwj