Remove unused styles on Windows from gitian qt build #1726

laanwj commented at 6:24 PM on August 26, 2012: member

Keeps the "windows", "windowsxp", "windowsvista" styles.

Reduces the size of a static bitcoin-qt.exe by ~400 kB.

luke-jr commented at 6:27 PM on August 26, 2012: member

Should bump the version number too (eg, qt-win32-4.7.4-gitian.zip => qt-win32-4.7.4-gitian-r1.zip).

laanwj commented at 6:41 PM on August 26, 2012: member

Done

in contrib/gitian-descriptors/qt-win32.yml:None in c54080b8bf outdated

  39 | @@ -40,7 +40,7 @@ script: |
  40 |    #export LD_PRELOAD=/usr/lib/faketime/libfaketime.so.1
  41 |    export FAKETIME=$REFERENCE_DATETIME
  42 |    export TZ=UTC
  43 | -  ./configure -prefix $INSTDIR -confirm-license -release -opensource -static -no-qt3support -xplatform unsupported/win32-g++-cross -no-multimedia -no-audio-backend -no-phonon -no-phonon-backend -no-declarative -no-script -no-scripttools -no-javascript-jit  -no-webkit -no-svg -no-xmlpatterns -no-sql-sqlite -no-nis -no-cups -no-iconv -no-dbus -no-gif -no-libtiff -opengl no -nomake examples -nomake demos -nomake docs
  44 | +  ./configure -prefix $INSTDIR -confirm-license -release -opensource -static -no-qt3support -xplatform unsupported/win32-g++-cross -no-multimedia -no-audio-backend -no-phonon -no-phonon-backend -no-declarative -no-script -no-scripttools -no-javascript-jit  -no-webkit -no-svg -no-xmlpatterns -no-sql-sqlite -no-nis -no-cups -no-iconv -no-dbus -no-gif -no-libtiff -opengl no -nomake examples -nomake demos -nomake docs -no-feature-style-plastique -no-feature-style-cleanlooks -no-feature-style-motif -no-feature-style-cde -no-feature-style-windowsce -no-feature-style-windowsmobile -no-feature-style-s60

Diapolo commented at 6:55 PM on August 26, 2012:

After -no-javascript-jit there is an unneeded space, which you could remove. And btw. now I know where the Qt static build is coming from ^^ -static. I have 2 additional switches in my local configure line, which are -no-dsp -no-vcproj. As far as I remember they are only needed for MSVC support.

Edit: And shouldn't it read -no-opengl instead of -opengl no?

Edit 2: Sorry for that many edits, but I tried the -no-feature-style-cde on Windows and I need to supply -no-style-cde for configure to work. Could be a change with Qt 4.8.2 but I wanted to mention it at least :).

Diapolo commented at 6:55 PM on August 26, 2012: none

Nice small find :).

laanwj commented at 3:37 AM on August 27, 2012: member

Are you sure?

-no-style-XXX didn't work here, even causes an option parse error in configure, though it is mentioned in the online documentation: http://doc.qt.nokia.com/4.7-snapshot/configure-options.html . no-style-XXX options are no longer mentioned in the configure documentation (configure --help) and the configure bash script that is used on unix-like systems.

-no-feature-style-XXX, however works... both in Qt 4.7.4 and Qt 4.8.1, in cross-compile. This may be a difference with configure.exe that you're using to configure on Windows.

Edit: now I'm sure of this: -no-dsp and no-vcproj don't even exist in configure. The -opengl no seems to work, as Qt OpenGL is not built.

Diapolo commented at 5:57 AM on August 27, 2012: none

Can for sure be a difference between configure and configure.exe and if it works everything is fine :). But at least the -no-opengl seems correct, when you use configure --help you should be able to verify that.

laanwj commented at 2:37 PM on August 27, 2012: member

Yep, I've verified, -no-opengl seems to be interchangable with -opengl no.

Diapolo commented at 2:42 PM on August 27, 2012: none

Good to know :).

Remove unused styles on Windows from gitian qt build

Keeps the "windows", "windowsxp", "windowsvista" styles.

Reduces the size of a static bitcoin-qt.exe by ~400 kB.

e598b5b5c2

BitcoinPullTester commented at 12:32 PM on August 30, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e598b5b5c2343bcb08bcf804249bdb67180baa41 for binaries and test log.

gavinandresen commented at 3:41 PM on September 5, 2012: contributor

ACK. Should we pull this for 0.7rc2 ?

Diapolo commented at 3:57 PM on September 5, 2012: none

The pull makes sense and I also used the switches in my own builds and they work (and do not harm bitcoin-qt.exe for me), so I'll vote ACK for 0.7rc2.

laanwj commented at 5:53 PM on September 5, 2012: member

I think it's safe to pull this for rc2. Though it means we all have to rebuild qt for the next release.

gavinandresen commented at 5:56 PM on September 5, 2012: contributor

missed it by THAT MUCH ||

laanwj referenced this in commit b9a4aaad1e on Sep 7, 2012

laanwj merged this on Sep 7, 2012

laanwj closed this on Sep 7, 2012

laanwj deleted the branch on Apr 9, 2014

owlhooter referenced this in commit ccbd5273ec on Oct 10, 2018

owlhooter referenced this in commit f9f28e7c73 on Oct 10, 2018

KolbyML referenced this in commit 7b2b9d048e on Dec 5, 2020

DrahtBot locked this on Sep 8, 2021