build: proper fix for the kerning issue in macOS build fixes #16836

RandyMcMillan commented at 11:37 am on October 27, 2019: contributor

After reading the librsvg documentation I realized that the svg settings were confusing the library. In this case it is best to set view box dimensions.

The documentation states:

If there are no width or height attributes in the toplevel - librsvg looks for the viewBox attribute. If present, this defines the aspect ratio and a “natural” size in pixels.

https://developer.gnome.org/rsvg/stable/ch02.html#id-1.2.4.2.6

LINE:4 Buy omitting the width and height attribs - we allow the librsvg to do its own interpretation in context.

LINE:26-32 By nesting the vector elements - we wrap the arrow into the text box. This keeps the arrow’s coordinates relative to the text element.

LINE:29 Make the arrow grey to match the text.

Screen Shot 2019-10-27 at 9 27 20 AM

Thanks for your patience while I researched this and found a proper fix!

RM

DrahtBot added the label Build system on Oct 27, 2019

DrahtBot added the label Scripts and tools on Oct 27, 2019

in contrib/macdeploy/background.svg:27 in 038b58d97f outdated

52+      <stop offset="80%" style="stop-color:rgb(205,205,205);stop-opacity:1" />
53+      <stop offset="100%" style="stop-color:rgb(204,204,204);stop-opacity:1" />
54+    </linearGradient>
55+  </defs>
56+<rect width="1000" height="640" style="fill:url(#gradient);stroke-width:0" />
57+  <g transform="translate(500,0) scale(1.0, 1.0)">

promag commented at 3:52 pm on October 27, 2019:

Why this change?

RandyMcMillan commented at 8:02 pm on October 27, 2019:

@promag - according to documentation the scaling/aspect ratio is taken care of in the preserveAspectRatio flag in

LINE:4

0<svg version="1.0" xmlns="http://www.w3.org/2000/svg" width="1000pt" height="640pt" viewBox="0 0 1000 640" preserveAspectRatio="xMidYMid meet">

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/preserveAspectRatio

0Meet or slice reference
1The meet or slice reference is optional and, if provided, must be one of the following keywords:
2meet (the default) - Scale the graphic such that:
3aspect ratio is preserved
4the entire viewBox is visible within the viewport
5the viewBox is scaled up as much as possible, while still meeting the other criteria

RandyMcMillan commented at 8:06 pm on October 27, 2019:

Also https://developer.gnome.org/rsvg/stable/recommendations-assets.html

RandyMcMillan commented at 8:56 pm on October 27, 2019:

Why this change?

Here is the result with the previous scale settings

Screen Shot 2019-10-27 at 4 53 02 PM

RandyMcMillan commented at 9:00 pm on October 27, 2019:

@promag - now that I have a better understanding of how to configure this - it is now more of an aesthetic choice than dealing with a kerning issue. In fact I plan to rework the whole presentation in a later PR - I just want to fix the glaring issue now - then focus on a better presentation later.

promag commented at 3:52 pm on October 27, 2019: member

Should just replace width and height attributes with viewBox?

fanquake added the label macOS on Oct 27, 2019

fanquake renamed this:
~~build:proper fix for the kerning issue in macOS build fixes #16836~~
build: proper fix for the kerning issue in macOS build fixes #16836
on Oct 28, 2019

promag commented at 8:16 am on October 28, 2019: member

Can you avoid the indentation change?

laanwj commented at 9:56 am on October 28, 2019: member

I just want to fix the glaring issue now

Yes, let’s do the minimal change to fix the issue. This shouldn’t need to go through multiple iterations and bikeshedding PRs. :smile:

fanquake added the label Waiting for author on Oct 28, 2019

RandyMcMillan closed this on Oct 28, 2019

RandyMcMillan commented at 5:13 pm on October 28, 2019: contributor

Part of the issue with this is - the previous version of this file isn’t valid svg.

Anyway here is the result of the PR rebuilt and minimized diffs.

Screen Shot 2019-10-28 at 1 06 42 PM @laanwj @promag - I pushed a diff minimized commit.

NOTE: https://travis-ci.org/RandyMcMillan/bitcoin/jobs/604022209

My original PR was passing. That is part of the problem I am trying to fix. https://travis-ci.org/RandyMcMillan/bitcoin/builds/603520733

RandyMcMillan reopened this on Oct 28, 2019

laanwj commented at 8:15 pm on October 28, 2019: member

Hmm, I think the whitespace lint is over-eager here, it should probably ignore image files.

RandyMcMillan closed this on Oct 30, 2019

fanquake removed the label Waiting for author on May 28, 2020

fanquake locked this on Aug 14, 2020

build: proper fix for the kerning issue in macOS build fixes #16836 #17273