code for blocksonly disagrees with documentation #17294

1. 
   dooglus commented at 0:53 am on October 29, 2019: contributor

   The docs for blocksonly say that “Transactions from the wallet or RPC are not affected” but the code says:

   if (gArgs.GetBoolArg("-blocksonly", DEFAULT_BLOCKSONLY) && gArgs.SoftSetBoolArg("-walletbroadcast", false)) {
       LogPrintf("%s: parameter interaction: -blocksonly=1 -> setting -walletbroadcast=0\n", __func__);
   }
   

   Here’s the relevant documentation:

   -blocksonly
      Whether to reject transactions from network peers. Transactions from the
      wallet or RPC are not affected. (default: 0)
   
   -walletbroadcast
      Make the wallet broadcast transactions (default: 1)
   

   Doesn’t that imply that blocksonly does affect transactions from the wallet?

2. dooglus added the label Bug on Oct 29, 2019
3. 
   MarcoFalke commented at 1:17 pm on October 29, 2019: member

   Correct. The documentation should be updated.
4. MarcoFalke added the label Docs on Oct 29, 2019
5. MarcoFalke added the label good first issue on Oct 29, 2019
6. 
   MarcoFalke commented at 1:18 pm on October 29, 2019: member

   My bad in fa8ced32a60dea37ac169241cf9a1f708ef46c4b
7. 
   birtony commented at 3:52 pm on October 29, 2019: none

   Hey, I would be happy to work on this!
8. MarcoFalke added the label Up for grabs on Dec 4, 2019
9. 
   glowang commented at 11:46 pm on March 14, 2020: contributor

   I will work on this!
10. glowang referenced this in commit aeec15f0f5 on Mar 20, 2020
11. fanquake removed the label Up for grabs on Mar 23, 2020
12. glowang referenced this in commit 1d503e7beb on Mar 25, 2020
13. glowang referenced this in commit 3019ba95a4 on Mar 25, 2020
14. glowang referenced this in commit be1b3b94cc on Mar 25, 2020
15. glowang referenced this in commit 9a7d39bd05 on Mar 25, 2020
16. glowang referenced this in commit 869327ca6e on Mar 26, 2020
17. glowang referenced this in commit 408585f8f1 on Mar 29, 2020
18. MarcoFalke closed this on Mar 29, 2020

    ---

19. DrahtBot locked this on Feb 15, 2022
20. vijaydasmp referenced this in commit 744970234d on Mar 24, 2022
21. vijaydasmp referenced this in commit 6000028733 on Mar 27, 2022
22. vijaydasmp referenced this in commit 4f27607598 on Mar 28, 2022
23. vijaydasmp referenced this in commit e736406c6f on Mar 31, 2022
24. vijaydasmp referenced this in commit 53cc35017c on Mar 31, 2022
25. vijaydasmp referenced this in commit 42ddb4546d on Mar 31, 2022
26. vijaydasmp referenced this in commit 89c3e09c97 on Mar 31, 2022
27. vijaydasmp referenced this in commit c2269e1670 on Apr 1, 2022
28. vijaydasmp referenced this in commit 29c78e2f44 on Apr 2, 2022

Contributors
dooglus MarcoFalke birtony glowang

Labels
Bug Docs good first issue