cli: Add "headers" and "verificationprogress" to -getinfo #17302

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2019_10_getinfo changing 1 files +2 −0

laanwj commented at 6:38 PM on October 29, 2019: member

These values are useful to know the current progress of initial sync, or of catching up, which is arguably the use of a quick -getinfo command.
laanwj added the label Utils/log/libs on Oct 29, 2019
hebasto commented at 6:53 PM on October 29, 2019: member

Concept ACK. There is a typo in commit message in "verifcationprogress".
laanwj renamed this:
~~cli: Add "headers" and "verifcationprogress" to -getinfo~~
cli: Add "headers" and "verificationprogress" to -getinfo
on Oct 29, 2019

cli: Add "headers" and "verificationprogress" to -getinfo

These value are useful to know the current progress of
initial sync, or of catching up.

31879345ee

laanwj force-pushed on Oct 29, 2019
laanwj commented at 7:03 PM on October 29, 2019: member

Thanks, fixed
MarcoFalke commented at 1:21 AM on October 30, 2019: member

unsigned ACK 31879345ee9a222b12014c8b2359e1737ff0d8c4
jonasschnelli commented at 6:23 AM on October 30, 2019: contributor

utACK 31879345ee9a222b12014c8b2359e1737ff0d8c4

jonatack commented at 10:37 AM on October 30, 2019: member

Tested ACK 31879345ee9a222b12014c8b2359e1737ff0d8c4 on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux

$ src/bitcoin-cli -getinfo
{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 601626,
  "headers": 601626,
  "verificationprogress": 0.9999914194982424,
  "timeoffset": -1,
  "connections": 10,
  "proxy": "",
  "difficulty": 13691480038694.45,
  "chain": "main",
  "walletversion": 169900,
  "balance": 0.00649423,
  "keypoololdest": 1551909091,
  "keypoolsize": 1000,
  "paytxfee": 0.00000000,
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

hebasto commented at 10:51 AM on October 30, 2019: member

Tested 31879345ee9a222b12014c8b2359e1737ff0d8c4 on Linux Mint 19.2:

$ src/bitcoin-cli -getinfo
{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 0,
  "headers": 404000,
  "verificationprogress": 2.127373228171698e-09,
  "timeoffset": 0,
  "connections": 1,
  "proxy": "",
  "difficulty": 1,
  "chain": "main",
  "walletversion": 169900,
  "balance": 0.00000000,
  "keypoololdest": 1572432296,
  "keypoolsize": 1000,
  "paytxfee": 0.00000000,
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

$ src/bitcoin-cli -getinfo
{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 497,
  "headers": 601628,
  "verificationprogress": 1.076450663093587e-06,
  "timeoffset": 0,
  "connections": 4,
  "proxy": "",
  "difficulty": 1,
  "chain": "main",
  "walletversion": 169900,
  "balance": 0.00000000,
  "keypoololdest": 1572432296,
  "keypoolsize": 1000,
  "paytxfee": 0.00000000,
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

Exponential formatting of "verificationprogress" seems a bit awkward.

laanwj commented at 11:34 AM on October 30, 2019: member

Exponential formatting of "verificationprogress" seems a bit awkward.

Yes. But out of scope of this issue as I have no control over formatting as long as we're using JSON here. A progress bar would be nicer I guess. See also #17314.
laanwj referenced this in commit edd9d0781b on Oct 30, 2019
laanwj merged this on Oct 30, 2019
laanwj closed this on Oct 30, 2019
alejagapatrick commented at 8:49 AM on April 9, 2020: none

src/bitcoin-cli.cpp
fanquake locked this on Apr 9, 2020

Contributors

Labels

Linked (view graph)

#17314 Re-thinking `bitcoin-cli -getinfo`