cli: Add “headers” and “verificationprogress” to -getinfo #17302

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2019_10_getinfo changing 1 files +2 −0
  1. laanwj commented at 6:38 pm on October 29, 2019: member
    These values are useful to know the current progress of initial sync, or of catching up, which is arguably the use of a quick -getinfo command.
  2. laanwj added the label Utils/log/libs on Oct 29, 2019
  3. hebasto commented at 6:53 pm on October 29, 2019: member
    Concept ACK. There is a typo in commit message in “verifcationprogress”.
  4. laanwj renamed this:
    cli: Add "headers" and "verifcationprogress" to -getinfo
    cli: Add "headers" and "verificationprogress" to -getinfo
    on Oct 29, 2019
  5. cli: Add "headers" and "verificationprogress" to -getinfo
    These value are useful to know the current progress of
    initial sync, or of catching up.
    31879345ee
  6. laanwj force-pushed on Oct 29, 2019
  7. laanwj commented at 7:03 pm on October 29, 2019: member
    Thanks, fixed
  8. MarcoFalke commented at 1:21 am on October 30, 2019: member
    unsigned ACK 31879345ee9a222b12014c8b2359e1737ff0d8c4
  9. jonasschnelli commented at 6:23 am on October 30, 2019: contributor
    utACK 31879345ee9a222b12014c8b2359e1737ff0d8c4
  10. jonatack commented at 10:37 am on October 30, 2019: member

    Tested ACK 31879345ee9a222b12014c8b2359e1737ff0d8c4 on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux

     0$ src/bitcoin-cli -getinfo
     1{
     2  "version": 199900,
     3  "protocolversion": 70015,
     4  "blocks": 601626,
     5  "headers": 601626,
     6  "verificationprogress": 0.9999914194982424,
     7  "timeoffset": -1,
     8  "connections": 10,
     9  "proxy": "",
    10  "difficulty": 13691480038694.45,
    11  "chain": "main",
    12  "walletversion": 169900,
    13  "balance": 0.00649423,
    14  "keypoololdest": 1551909091,
    15  "keypoolsize": 1000,
    16  "paytxfee": 0.00000000,
    17  "relayfee": 0.00001000,
    18  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
    19}
    
  11. hebasto commented at 10:51 am on October 30, 2019: member

    Tested 31879345ee9a222b12014c8b2359e1737ff0d8c4 on Linux Mint 19.2:

     0$ src/bitcoin-cli -getinfo
     1{
     2  "version": 199900,
     3  "protocolversion": 70015,
     4  "blocks": 0,
     5  "headers": 404000,
     6  "verificationprogress": 2.127373228171698e-09,
     7  "timeoffset": 0,
     8  "connections": 1,
     9  "proxy": "",
    10  "difficulty": 1,
    11  "chain": "main",
    12  "walletversion": 169900,
    13  "balance": 0.00000000,
    14  "keypoololdest": 1572432296,
    15  "keypoolsize": 1000,
    16  "paytxfee": 0.00000000,
    17  "relayfee": 0.00001000,
    18  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
    19}
    

     0$ src/bitcoin-cli -getinfo
     1{
     2  "version": 199900,
     3  "protocolversion": 70015,
     4  "blocks": 497,
     5  "headers": 601628,
     6  "verificationprogress": 1.076450663093587e-06,
     7  "timeoffset": 0,
     8  "connections": 4,
     9  "proxy": "",
    10  "difficulty": 1,
    11  "chain": "main",
    12  "walletversion": 169900,
    13  "balance": 0.00000000,
    14  "keypoololdest": 1572432296,
    15  "keypoolsize": 1000,
    16  "paytxfee": 0.00000000,
    17  "relayfee": 0.00001000,
    18  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
    19}
    

    Exponential formatting of “verificationprogress” seems a bit awkward.

  12. laanwj commented at 11:34 am on October 30, 2019: member

    Exponential formatting of “verificationprogress” seems a bit awkward.

    Yes. But out of scope of this issue as I have no control over formatting as long as we’re using JSON here. A progress bar would be nicer I guess. See also #17314.

  13. laanwj referenced this in commit edd9d0781b on Oct 30, 2019
  14. laanwj merged this on Oct 30, 2019
  15. laanwj closed this on Oct 30, 2019

  16. alejagapatrick commented at 8:49 am on April 9, 2020: none
    src/bitcoin-cli.cpp
  17. fanquake locked this on Apr 9, 2020

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me