Re-thinking bitcoin-cli -getinfo #17314

issue laanwj openend this issue on October 30, 2019
  1. laanwj commented at 10:16 am on October 30, 2019: member

    Now that getinfo is no longer part of the RPC API, and client-side implementation is not subject to API stability, it’s possible to start thinking about making it more user friendly.

    I’ve made a start in #17302 by adding some status fields.

    Some other potential ideas:

    • Remove noise: fields that users are unlikely to want to query often protocolversion, walletversion, keypoololdest (these three were done in #17650)
    • Multiwallet: List balance per wallet
    • List all proxies, at least if they’re different from the IPv4 one
    • Alternative, more human-friendly, format besides JSON? Colors, progress bars :smile:?
  2. laanwj added the label Feature on Oct 30, 2019
  3. laanwj added the label Utils/log/libs on Oct 30, 2019
  4. laanwj added the label good first issue on Oct 30, 2019
  5. MarcoFalke commented at 1:01 pm on October 30, 2019: member
    We also need more emojis, obviously
  6. malevolent commented at 11:31 am on November 30, 2019: contributor
    Hi @laanwj @MarcoFalke , This change removes the noisy unwanted fields listed under your first potential idea. If there is anything I should add or change please let me know.
  7. malevolent referenced this in commit ad60f385a3 on Dec 3, 2019
  8. malevolent referenced this in commit 868a322286 on Dec 3, 2019
  9. malevolent referenced this in commit 01c8701559 on Dec 4, 2019
  10. fanquake closed this on Dec 4, 2019

  11. fanquake reopened this on Dec 4, 2019

  12. sidhujag referenced this in commit 46154724ed on Dec 4, 2019
  13. jonatack commented at 9:34 pm on March 28, 2020: member
    Adding point 2 (Multiwallet: List balance per wallet). Proposals here if anyone would like to weigh in.
  14. HashUnlimited referenced this in commit de84daf64f on Apr 17, 2020
  15. meshcollider referenced this in commit 24f7029064 on May 23, 2020
  16. sidhujag referenced this in commit f17ae817ed on May 25, 2020
  17. sidhujag referenced this in commit 0ca1b0213e on Nov 10, 2020
  18. backpacker69 referenced this in commit fb012e5e61 on Mar 28, 2021
  19. klementtan commented at 3:34 pm on July 22, 2021: contributor

    Some ideas from #21832 to further improve -getinfo:

    1. Refactor ParseGetInfoResult() to be a method of ParseGetInfoResult class
    2. Allow ANSI color codes on WIN32 with this command.
      • #21832#pullrequestreview-673668850
    3. Display date/time of latest block verified (maybe even the delta to the current time, to immediately see how far one is behind during IBD, or how long ago the last block was received, respectively)
      • #21832#pullrequestreview-673668850
    4. show on-disk size of the block chain (getblockchaininfo returns a field “size_on_disk”)
      • #21832#pullrequestreview-682424334
    5. show whether pruning is enabled
      • #21832#pullrequestreview-682424334
    6. verification progress bar (implemented in #22547)
      • #21832#pullrequestreview-682424334
  20. ghost commented at 3:42 am on August 2, 2021: none

    @klementtan -getinfo has no section for mempool

    Should we add something from getmempoolinfo ?

    Can start by adding size, unbroadcast count and maxmempool. Maybe add below things later if enough people agree:

    0====================== | 1-5
    1==========             | 5-10
    2====                   | 10-50
    3=                      | 100-200
    4
    5Size (vMB)             | Fee rate (sat/vByte)
    
  21. klementtan commented at 11:57 am on August 4, 2021: contributor
    @prayank23 SGTM! 👍🏻
  22. laanwj referenced this in commit d809d8bf12 on Sep 20, 2021
  23. sidhujag referenced this in commit d862d3f796 on Sep 21, 2021
  24. MarcoFalke commented at 2:41 pm on October 26, 2021: member
    Anything left to do here?
  25. ghost commented at 6:09 am on October 27, 2021: none
  26. Stackout referenced this in commit ecfdf78f85 on Feb 17, 2022
  27. ghost commented at 12:03 pm on March 5, 2022: none
    Nothing is left. This issue can be closed.
  28. fanquake closed this on Mar 5, 2022

  29. knst referenced this in commit 8bc4db8a66 on May 26, 2022
  30. knst referenced this in commit c4314ce75a on May 27, 2022
  31. knst referenced this in commit 00fbb89b10 on May 30, 2022
  32. DrahtBot locked this on Mar 5, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-18 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me