Fix input size assertion in wallet_bumpfee.py #17322

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:w_bp_assert changing 1 files +6 −6

instagibbs commented at 5:01 PM on October 30, 2019: member

I was investigating a curious error for #17290 and realized that this check should have caught that error earlier in the test.

The loop is intended to ensure that only a single input exists the entire time until the change output disappears, a single additional bump occurs, then it leaves the loop.
fanquake added the label Tests on Oct 30, 2019
theStack approved
theStack commented at 8:05 PM on November 10, 2019: member

ACK 1ac553c3ab613dea73462be496803d2ee0489d67
MarcoFalke commented at 7:26 PM on November 11, 2019: member

What about renaming both to the same name? e.g. input_list, since it always refers to the input list, regardless of what iteration we are on.
instagibbs commented at 7:50 PM on November 11, 2019: member

What about renaming both to the same name?

IIRC it made it easier for me to think about the test as I wrote it, but if others find that clearer I can do that too
Fix input size assertion in wallet_bumpfee.py 38516f9078
instagibbs force-pushed on Nov 15, 2019
instagibbs commented at 6:59 PM on November 15, 2019: member

In the interest of a quicker merge of this clear test bug, took Marco's suggestion
MarcoFalke commented at 7:01 PM on November 15, 2019: member

Sorry, I think the previous solution was also fine. Just forgot about this.
MarcoFalke referenced this in commit 422ec33d45 on Nov 15, 2019
MarcoFalke merged this on Nov 15, 2019
MarcoFalke closed this on Nov 15, 2019
sipa deleted a comment on Jul 7, 2020
sipa deleted a comment on Jul 7, 2020
sipa deleted a comment on Jul 7, 2020
sipa deleted a comment on Jul 7, 2020
sipa deleted a comment on Jul 7, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#17290 Enable BnB coin selection for preset inputs and subtract fee from outputs