depends: update README.md with working Android targets and API levels #17365

pull icota wants to merge 2 commits into bitcoin:master from icota:update-android-depends-doc changing 1 files +17 −9

icota commented at 3:15 PM on November 4, 2019: contributor

Per @Sjors comments in #16110#pullrequestreview-310821810
depends: update README.md with working Android targets and API levels aa9b84acee
fanquake added the label Docs on Nov 4, 2019

in depends/README.md:39 in aa9b84acee outdated

  34 |  - `aarch64-linux-android` for Android ARM 64 bit
  35 | +- `i686-linux-android` for Android x86 32 bit
  36 | +- `x86_64-linux-android` for Android x86 64 bit
  37 |  
  38 |  The paths are automatically configured and no other options are needed unless targeting Android.
  39 |  Before proceeding with an Android build one needs to get the [Android SDK](https://developer.android.com/studio) and use the "SDK Manager" tool to download the NDK and one or more "Platform packages" (these are Android versions and have a corresponding API level).

laanwj commented at 4:49 PM on November 4, 2019:

Maybe make this information for Android a separate section (but refer to it here)

icota commented at 9:36 AM on November 5, 2019:

Sure thing

depends: move README.md Android instructions to a separate section 3fe1aba601
emilengler commented at 1:20 PM on November 5, 2019: contributor

Wouldn't it be better to create a file for this in the doc folder and link to it in the README?
icota commented at 1:43 PM on November 5, 2019: contributor

I don't think so. This is specific to depends and other platform cross-compilation instructions are in the same file.
Sjors commented at 1:50 PM on November 5, 2019: member

It's fine. It's not that long yet, and if you search the repo for Android you'll find it :-)

ACK 3fe1aba
MarcoFalke referenced this in commit e204dc11b5 on Nov 5, 2019
MarcoFalke merged this on Nov 5, 2019
MarcoFalke closed this on Nov 5, 2019
cryptozeny commented at 2:51 PM on November 5, 2019: none

thanks alot!
icota deleted the branch on Nov 5, 2019
Sjors commented at 3:31 PM on November 5, 2019: member

Future note: please don't tag Github usernames in commit messages; it results in spam when altcoins backport it. My own fault for missing that :-)
icota commented at 8:16 AM on November 6, 2019: contributor

You didn't miss anything. :smile:

I read CONTRIBUTING like a good boy so I didn't include it in any commit messages. Merge commit picked it up from the first comment though. Should we avoid that?
Sjors commented at 8:58 AM on November 6, 2019: member

No, I think the merge script should take care of that. I thought it stripped the @. @MarcoFalke?
laanwj commented at 9:47 AM on November 6, 2019: member

No, it doesn't strip them—as this might corrupt, say, mail addresses, github's parsing is pretty ambigious and heuristic-based and replicating this is non-trivial! it warns when there are any before merging, though
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16110 depends: Add Android NDK support