wallet_importmulti: use addresses of the same type as being imported #17387

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:tests-fix-getaddrinfo-type-consistency changing 1 files +12 −12

achow101 commented at 10:21 PM on November 5, 2019: member

When constructing an import from the solving data of an address, make sure that the original address is the same type as the one that will be imported.

See also: #17374 (comment)

Part of #17261
fanquake added the label Tests on Nov 5, 2019
meshcollider approved
meshcollider commented at 10:46 PM on November 5, 2019: contributor

Code review ACK b8c37fc8e634cd6abb16d361812a96d101d8cd7d

wallet_importmulti: use addresses of the same type as being imported

When constructing an import from the solving data of an address,
make sure that the original address is the same type as the one that
will be imported.

b84e776fd1

achow101 force-pushed on Nov 5, 2019
achow101 commented at 11:31 PM on November 5, 2019: member

Ooops, missed a couple spots.
Sjors commented at 7:39 AM on November 6, 2019: member

Code review ACK b84e776
meshcollider commented at 9:19 PM on November 22, 2019: contributor

Tested re-ACK b84e776fd166ac422ac4a0dcdc1c6f7fd921bf70
meshcollider referenced this in commit 4effd67bf4 on Nov 22, 2019
meshcollider merged this on Nov 22, 2019
meshcollider closed this on Nov 22, 2019
laanwj commented at 9:21 PM on November 22, 2019: member

ACK b84e776fd166ac422ac4a0dcdc1c6f7fd921bf70, better to have this explicit
sidhujag referenced this in commit b609c9ed8a on Nov 22, 2019
sidhujag referenced this in commit 49ef95dc89 on Nov 10, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17261 Make ScriptPubKeyMan an actual interface and the wallet to have multiple #17374 IsMine: Set state to WATCH_ONLY if we can get the pubkey