This small change enables forks to use the TravisCI tests.
Build: add REPO_SLUG to fix errors in forked builds #17418
pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:repo-slug changing 2 files +4 −2-
RandyMcMillan commented at 2:24 PM on November 8, 2019: contributor
-
696b951556
Build: add REPO_SLUG to fix errors in forked builds
This eliminates error on forked repos in TravisCI instances
- fanquake added the label Tests on Nov 8, 2019
- fanquake requested review from MarcoFalke on Nov 8, 2019
-
RandyMcMillan commented at 4:32 PM on November 8, 2019: contributor
@hebasto - I am not sure if eliminating the if condition all together is a possibility.
-
MarcoFalke commented at 4:35 PM on November 8, 2019: member
What kind of errors?
-
RandyMcMillan commented at 5:19 PM on November 8, 2019: contributor
What kind of errors?
I believe this is an example. https://travis-ci.org/RandyMcMillan/bitcoin/jobs/608862338#L17505 https://travis-ci.org/RandyMcMillan/bitcoin/jobs/608862338#L17515
It seems the if condition is timing out builds. I could be missing something but this change seems have fixed it.
NOTE: If people are using a local environment then the $TRAVIS_REPO_SLUG will do the same thing. SoI believe it is best to make the logic compare an environment variable that is set up.
-
MarcoFalke commented at 5:26 PM on November 8, 2019: member
The error comes from
./ci/test/06_script_a.sh. Here you are modifying linters, so this can not be the right "fix". - MarcoFalke closed this on Nov 8, 2019
-
MarcoFalke commented at 5:27 PM on November 8, 2019: member
The error is
Error! Initial build successful, but not enough time remains to run later build stages and tests. Please manually re-run this job by using the travis restart button or asking a bitcoin maintainer to restart. The next run should not time out because the build cache has been saved.
Which means that your repository has a limit of 50 minutes. There is no code change that could fix that. You'd have to ask travis to increase it.
- RandyMcMillan deleted the branch on Nov 8, 2019
-
RandyMcMillan commented at 7:00 PM on November 8, 2019: contributor
Thanks - lesson learned - At least something useful came out of it.
- MarcoFalke referenced this in commit a8d9f7dfa7 on Nov 20, 2019
- sidhujag referenced this in commit 42caf11783 on Nov 20, 2019
- sidhujag referenced this in commit f5ef254714 on Nov 10, 2020
- Munkybooty referenced this in commit 1365fd54e1 on Jun 7, 2022
- Munkybooty referenced this in commit b2ea31d605 on Jun 8, 2022
- Munkybooty referenced this in commit 9f9c3dc725 on Jun 16, 2022
- DrahtBot locked this on Aug 16, 2022