build:fix "make clean" darwin build #17430

pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:fix-darwin-make-clean changing 1 files +2 −2

RandyMcMillan commented at 1:19 AM on November 10, 2019: contributor

This PR corrects an issue where make clean was not removing the .dmg

$make clean now works as expected. $make deploy still works as expected.

cleans Bitcoin-Qt.dmg, background.tiff bachground.png, background@2x.png as expected.

old config new config

The change was added to documentation but make clean needed to be updated. https://github.com/bitcoin/bitcoin/commit/4441e58497513cc55cfebfdcaaeee340f62f8062#diff-9de36befe13356841c2699ee0eff4a0aR14

The old config named the Bitcoin-Core.dmg based on the PACKAGE_NAME variable (which is still used for naming the Bitcoin Core.app (with space)).

build:fix "make clean" darwin build

cleans  Bitcoin-Qt.dmg, background.tiff
        bachground.png, background@2x.png
        as expected.

42de1a0700

fanquake added the label Build system on Nov 10, 2019
RandyMcMillan commented at 1:27 AM on November 10, 2019: contributor

NOTE:

I know that this is a similar PR to #17389

There is a documented bug in the macOS Github app that I was using to preview my PRs. Which I believe was force closing some PRs as one side effect.

#17389 (comment)
laanwj commented at 9:25 AM on November 10, 2019: member
@RandyMcMillan
- Don't tag people in the opening post of your PR. The initial post of the PR will end up in git, and when it's merged, the person will be tagged every time the commit ends up somewhere (for example, when ported to an altcoin).
- Please stop opening new PRs to replace old PRs for only minimal changes you keep doing this! As I've told you again and again, if you need to experiment with git a bit (which is not strange for a beginner), to get workflows like this right, please do so in your own repository, not ours.
RandyMcMillan closed this on Nov 24, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels