fix nMinerConfirmationWindow not initialized #17433

pull ghost wants to merge 1 commits into bitcoin:0.19 from changing 1 files +2 −2

ghost commented at 6:23 pm on November 10, 2019: none

fix nMinerConfirmationWindow not initialized
fix nMinerConfirmationWindow not initialized da0a2ce622
DrahtBot added the label Validation on Nov 10, 2019
MarcoFalke closed this on Nov 11, 2019
ghost commented at 9:39 pm on November 11, 2019: none

not even a comment why this was closed?
MarcoFalke commented at 10:01 pm on November 11, 2019: member
This stylistic change may make sense on its own, however it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:
- Time spent on review
- Accidental introduction of bugs
- (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.
For more information about refactoring changes and stylistic cleanup, see
Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

Let me know if you have any questions.
laanwj commented at 9:09 am on November 12, 2019: member

This is now #17449
fanquake locked this on Jul 27, 2020