remove unused variable - consensus.nMinerConfirmationWindow

ghost commented at 2:36 am on November 12, 2019: none

consensus.nMinerConfirmationWindow is initialized to 0 via the c++11 standard and never assigned a value. Code is not rearranged like the earlier pull request and is 100% equivalent. Leaving the code as is makes it appear as if there is a bug.

build: Bump version to 0.19.0

Prepare for 0.19.0rc1.

Tree-SHA512: 94be2a465ccba56252b6d9aa9ed493cebef4c37668fa7aad4caeb42ca60c6789b107eb0f3956ca91f846f5e8a55f85371864a5697c4e5474b64cb6c1acfe59b2

57eb126416

qt: Translations update pre-rc1

Tree-SHA512: d3bafa862826d90f281e753d1398c19c83f298ad22c86ab46999ef1a566df61a27ad127f35ea84f908620eec1c5c89e1b82505e7b3be94ca75f97e48706f34f5

76ec335234

Don't rename main thread at process level

Set only the internal name.

Fixes #17036 for both `bitcoind` and `bitcoin-qt`.

Github-Pull: #17038
Rebased-From: 07e4bdba3bd46c3a15dedb0a2660453c300643dc
Tree-SHA512: ed6f1b95a23c4c7863982ee6972429be5af0702ea93f0f17d32d2ef4b01446b1c0528eeadc45289609eda5c02ea68b3d722b8ecdfdf4fff4b02592c2188cc0a0

9fdaaecf49

qt: Periodic translations update

Pull new translations from Transifex.
Fixes #17027.

Tree-SHA512: 0c1708e9cf8180fd98715a078d49f417c78418b7c42fa31ca5a9c0d5766a54c217cef1f76a9edee1780d65635194536f2e63109a8a8560589aa2f6bb98d6b0de

6db76c6bc7

build: Fix boost detection on Ubuntu ARM 18.04

Update ax_boost_base.m4 to version in progress: autoconf-archive/autoconf-archive#198

This is a temporary workaround for the problem in the 0.19.0 release;
please pull in the upstream version when ready (see #17010).

Tree-SHA512: ea8c4e895f5414cd307a9d809d2ec35fa8de6a733d8bf66080b67634d27cfb8b8f6256ca583a73e3ad899eebb42e6fc256ea693ae735624f968b34469c626586

cd1e7bb064

Prevent processing duplicate payment requests

Github-Pull: #17031
Rebased-From: 3f89e1eb237efcbd6415ca2cd0acddb6596153d7
Tree-SHA512: da428b0d70c06a99c948d7d4af0827e517b6d93be11a7462a73cca2b829cc3e40e74eadca5c3148e80be56a7a64213507243a5d7d7e67d5d74317f3c07f2ef16

bd22dea633

doc: Update manpages

Tree-SHA512: c8fa2ce869402f5c8e5e8fd8c835cce5d1ba482cb784613ea074a98e7a1035ab64f832f4232d745fc7c79966e5201be4c843af45f36284653e793965bb415e0e

913972944b

qt: Periodic translations update

Remove stale translations. Closes #17061.

Tree-SHA512: c1540a5ccd63944c069b58fc6e3ec50e10e380c5de01a09a75b8971d4ffeedf3d09fbb33fed0e1a773a9258b370d97885dc4e8e6c0eff36ef68f2cf1e7c9d103

3a7b2a15e3

tests: Fix fs_tests for unknown locales

Fix by removing "L" as suggested by meeDamian in
https://github.com/bitcoin/bitcoin/issues/14948#issuecomment-522355441

Co-Authored-By: bugs@meedamian.com

Github-Pull: #17086
Rebased-From: d48f664

bd9d40dbbd

Merge #17158: tests: Fix fs_tests for unknown locales

bd9d40dbbdc0ee4c7f1d56202a984ca7222d4708 tests: Fix fs_tests for unknown locales (Daki Carnhof)

Pull request description:

  Backporting to `0.19` as suggested in https://github.com/bitcoin/bitcoin/pull/17086#issuecomment-542297344

  Fix by removing "L" as suggested by meeDamian in
  https://github.com/bitcoin/bitcoin/issues/14948#issuecomment-522355441

  Co-Authored-By: bugs@meedamian.com

Top commit has no ACKs.

Tree-SHA512: cb73c475560d156034d240c77dfd704526cfb148bcecf302079f1f9b6984117da71f018e1c70a165caed90be48482cb9c4939b001477a44f562fc0c11cb6ede7

3834d3d121

init: Change fallback locale to C.UTF-8

Much of our code assumes UTF-8 support, and this is a more realistic
guess for modern systems anyway than the default character set (which
would be ASCII only). So change the assumed fallback locale (if no
locale is defined by the user or OS) to `C.UTF-8`.

Github-Pull: #17085
Rebased-From: facb9a1315f97489a20eb0e969fdb14b5128ed2f

ba46f39418

util: Filter control characters out of log messages

Belts and suspenders: make sure outgoing log messages don't contain
potentially suspicious characters, such as terminal control codes.

This escapes control characters except newline ('\n') in C syntax.
It escapes instead of removes them to still allow for troubleshooting
issues where they accidentally end up in strings.

Github-Pull: #17095
Rebased-From: d7820a1250070f3640246ae497e049bee0b3516f

dc0fe7ae1f

doc: update bips.md with buried BIP9 deployments

Github-Pull: #17111
Rebased-From: fa6ed82794f4aecbd71667b5491edbbc4eaeaaef

6a45766acb

rpc: fix -rpcclienttimeout 0 option

Github-Pull: #17131
Rebased-From: b3b26e149c34fee9c7ae8548c6e547ec6254b441

e1bacb591a

util: Filter out macOS process serial number

Github-Pull: #17184
Rebased-From: b5f0be38790ecc87a1e537edeca5923f608bc68c

334e27ed5a

Merge #17197: [0.19.0] Backports

334e27ed5aae2dbe767b73eac8876edf5ab2b797 util: Filter out macOS process serial number (Hennadii Stepanov)
e1bacb591a75375461cdf9e39e4dda4acdbd6981 rpc: fix -rpcclienttimeout 0 option (Fabian Jahr)
6a45766acbf4fc8d2ce8ab3e1eb1afc85a7c05ca doc: update bips.md with buried BIP9 deployments (MarcoFalke)
dc0fe7ae1f941a2aafc29a0c7b7068e160583ef4 util: Filter control characters out of log messages (Wladimir J. van der Laan)
ba46f394182dc2ac85ea7e0a7b6141312180de73 init: Change fallback locale to C.UTF-8 (Wladimir J. van der Laan)

Pull request description:

  Backports the following PRs to the `0.19.0` [branch](https://github.com/bitcoin/bitcoin/tree/0.19):
  * #17184 -  util: Filter out macOS process serial number
  * #17131 - rpc: fix -rpcclienttimeout 0 option
  * #17111 - doc: update bips.md with buried BIP9 deployments
  * #17095 - util: Filter control characters out of log messages
  * #17085 - init: Change fallback locale to C.UTF-8

ACKs for top commit:
  laanwj:
    ACK  334e27ed5aae2dbe767b73eac8876edf5ab2b797

Tree-SHA512: 436064c00f98bae8475d0e46ab104df6fc9bdae4927dcdd5cffa4242704256c749352e9cabb23cf806911b1c303ddcb0208a42d540412e98da2513176e5e1023

5b68d1654f

gui: Make polling in ClientModel asynchronous

With this change polling runs in a different thread to prevent
disturbing the event loop.

Github-Pull: #17135
Rebased-From: 6b6be41c36e4fe9a74bed50e7f0a06532ab1260b

d5c36ce0c4

Merge #17252: 0.19: gui: Make polling in ClientModel asynchronous

d5c36ce0c4b92ee7a2b5f256ec5f73cd1c95d21d gui: Make polling in ClientModel asynchronous (João Barbosa)

Pull request description:

  Backport #17135.

ACKs for top commit:
  laanwj:
    ACK d5c36ce0c4b92ee7a2b5f256ec5f73cd1c95d21d, it is a clean cherry-pick of 6b6be41c36e4fe9a74bed50e7f0a06532ab1260b.

Tree-SHA512: 4e514f205866d87bdc19a57dede2214891237d7b663c9c8c9f19a9ab5c5a6e64876065bebb6c16a1799b02e0eb971318866b4e0824155b47063ce379fb0155e2

0f6f7a574a

http: add missing header bootlegged by boost < 1.72

httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
    std::deque<std::unique_ptr<WorkItem>> queue;
    ~~~~~^

Github-Pull: #17249
Rebased-From: a5929130223973636f3fd25fbfaf2953f2ec96a9
Tree-SHA512: 47ca773676a3f181bb265af30df6ca83669ffbb2dc79ce7c1ffd6f2d110df8406c2f73daddbcb1c038661472a1be93f46e9d3b8c3d2f33fe484f5774070e59ae

8082b3847a

gui: Fix start timer from non QThread

Github-Pull: #17120
Rebased-From: a8f5026d6d992fd8d72908c848c5028f0f9a8cd1
Tree-SHA512: 5f8cbfd5044d2c0df7dbfc54e7d94f93da96d0adecd23007e82acc38bc3c7984a685c9596cbd449f559cf42db9e1b99612765328004c5a45655a8e375482a8a8

e39c9cff1a

gui: disable font antialiasing for QR image address

More info available here: https://doc.qt.io/qt-5/qfont.html#StyleStrategy-enum

Github-Pull: #17257
Rebased-From: e156b9d8b974f57253306b693a03aa80322ebc6c
Tree-SHA512: 6e36d626215d5e66796bd3935037eef89ae810e4855e321f9f37b90c3be0b61de21cd655f23bc6a29f41038b5179d92578ab19ab89ccd525d9389ab868456827

eb5a899d5a

build: bump version to rc3

Tree-SHA512: 078c48b4bb0558c8600211b3cc6ae7e2ce6add7ea907da0100f862f51fcb1119639fddd028396fa79899dae8cab606bf388b3a4c92f3fbe8e191fda1b63c80fa

f6aab42bba

gui: rc3 translations update

Tree-SHA512: 84fae5ac33200ba995384f87d43c3d0b138043e47094dd62731e1558fdc74a8df283046437f1d0c228cdee519bbf9c167a1696a7a4d915f48da97c9524f320c2

7358ae6d71

doc: reintegrate release notes from wiki

Taken from revision https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.19.0-Release-Notes-Draft/3f6f33ba44c30be9b3b30e674ffc0652f26b6798.

2a15679816

doc: add macOS DMG opening note to release notes 8bca3ce0b1

cli: fix -getinfo output when compiled with no wallet

Github-Pull: #17368
Rebased-From: 3d05d332693ec860626fc77e6ba50dec94e4e83c

2d0b3c0716

Merge #17403: doc: reintegrate 0.19.0 release notes

8bca3ce0b121b77bec4915617dfceed4c023962c doc: add macOS DMG opening note to release notes (fanquake)
2a1567981644087793c54e267d633bd453c6b8a1 doc: reintegrate release notes from wiki (fanquake)

Pull request description:

  This reintegrates the WIP release notes from the [wiki](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.19.0-Release-Notes-Draft).

  This also adds a note to the release notes about macOS Catalina users having to "right click" and "Open" to open the DMG. Happy to adjust this as required.

ACKs for top commit:
  laanwj:
    ACK 8bca3ce0b121b77bec4915617dfceed4c023962c

Tree-SHA512: 7cd88159520d90b50903434221cf656928a964d407de64016ae5f8a35fdf29a631d765d7f99fd1d5339901b00db79e2fec6be214fa8016c95856f7a691b80b4d

84908668a0

build: set CLIENT_VERSION_RC to 0 pre-final

Tree-SHA512: 3d071f93f6fc5b30ccfb3ca34d7e050370d2d6201aca892503a4300a761116d69ceed7c770283581fcce0ce78ff7c0a6820db8600877d09fba9ed0cd488f4bf7

42414bfd05

doc: Clean out release notes post-release

Tree-SHA512: 8f54da0099227270a51e3ab82e001cca82aa3f2f8e6303cd31f9c9a4d2867113e2776f2a7babf4737cfca1830cf0077070621a0c3bb881d5f9d36dde0b0104d1

e05b2dba16

Merge #17417: [0.19] cli: fix -getinfo output when compiled with no wallet

2d0b3c07162a7050f48698069550f674b4599423 cli: fix -getinfo output when compiled with no wallet (fanquake)

Pull request description:

  Backports #17368 to the 0.19 branch.

ACKs for top commit:
  laanwj:
    ACK 2d0b3c07162a7050f48698069550f674b4599423, this is a clean backport of #17368 / 3d05d33 and contains the necessary metadata.

Tree-SHA512: 7773a1038df385ca3114454800142fb3c44b06894175641e596a17214f8e83b326ea049d8908d6ff7c6e56b07e671216196d2bb964401a6b5e0ec1e632fc8b89

c7c8e3e072

remove unused variable 1501fc3e63

MarcoFalke changed the base branch on Nov 12, 2019

MarcoFalke commented at 3:25 am on November 12, 2019: member

Ok, now I see what you did in #17433. Please restore the fix from #17433 and cherry-pick it on master. (We merge bug fixes to master and then backport them to old branches after they have been merged to master)

MarcoFalke added the label Consensus on Nov 12, 2019

MarcoFalke added the label Needs backport (0.19) on Nov 12, 2019

MarcoFalke added the label Bug on Nov 12, 2019

MarcoFalke commented at 3:31 am on November 12, 2019: member

consensus.nMinerConfirmationWindow is initialized to 0 via the c++11 standard

This is not true. It is uninitialized memory.

MarcoFalke added this to the milestone 0.19.1 on Nov 12, 2019

DrahtBot commented at 3:39 am on November 12, 2019: member

DrahtBot added the label Needs rebase on Nov 12, 2019

ghost commented at 3:52 am on November 12, 2019: none

Created new pull request on master for this:

fix uninitialized variable nMinerConfirmationWindow #17449

ghost commented at 3:56 am on November 12, 2019: none

consensus.nMinerConfirmationWindow is initialized to 0 via the c++11 standard

This is not true. It is uninitialized memory.

Yes you are right, there isn’t a = {}; to initializes all members to zero

laanwj commented at 9:07 am on November 12, 2019: member

Closing in favor of #17449

laanwj closed this on Nov 12, 2019

fanquake removed the label Needs backport (0.19) on Nov 14, 2019

fanquake removed the label Needs rebase on Nov 14, 2019

fanquake removed this from the milestone 0.19.1 on Nov 14, 2019

fanquake locked this on Jul 27, 2020

remove unused variable - consensus.nMinerConfirmationWindow #17448