Have RPC help text refer to correct "network" address type #17465

issue instagibbs opened this issue on November 13, 2019

instagibbs commented at 4:08 PM on November 13, 2019: member

Currently in RPC help there's a mixture of "Bitcoin address" and "bitcoin address" references everywhere.

I think it'd be a slight improvement to have the test return the name of the network its running on, with main, testnet3 aliased to their respective pet names "Bitcoin" and "testnet"(IIRC, might be wrong on the testnet point what the chain name is).
instagibbs added the label Feature on Nov 13, 2019
fanquake added the label Docs on Nov 13, 2019
MarcoFalke commented at 4:14 PM on November 13, 2019: member

generally we avoid making the help text dynamic on command line arguments. Especially when it is only test related. So NACK from me.
MarcoFalke removed the label Feature on Nov 13, 2019
MarcoFalke added the label Tests on Nov 13, 2019
instagibbs closed this on Nov 13, 2019
instagibbs commented at 4:23 PM on November 13, 2019: member

ok.
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels