rc upnp makefile ifdefs #175

issue trentzb opened this issue on April 20, 2011

trentzb commented at 8:42 PM on April 20, 2011: none
makefile.unix upnp ifdef doesn't seem to be working as intended unless I got an issue with my make (3.81).
```
tar xfz tarballs/bitcoin-0.3.21rc-linux.tar.gz
cd bitcoin-0.3.21/src
make -f makefile.unix bitcoind
g++ -c -O2 -Wno-invalid-offsetof -Wformat -g -D__WXDEBUG__ -DNOPCH -DFOURWAYSSE2 -DUSE_SSL -DUSE_UPNP=0 -o obj/nogui/util.o util.cpp
```
I use instead in makefile.unix
```
ifeq ($(USE_UPNP),1)
  LIBS += -l miniupnpc
  DEFS += -DUSE_UPNP
endif
```
It looks like it may need to be changed in makefile.*

I'm sorry but I don't know git yet so I could not fix myself. Learning git just moved up on my priority list though.

uname -a Linux bc0 2.6.35-22-generic #33-Ubuntu SMP Sun Sep 19 20:32:27 UTC 2010 x86_64 GNU/Linux make -v GNU Make 3.81
gavinandresen commented at 3:14 AM on April 21, 2011: contributor

What is the issue? -DUSE_UPNP=0 is correct, that means "compile in support for UPNP but do not turn it on by default"
trentzb commented at 6:38 AM on April 21, 2011: none

My mistake. I was assuming its purpose was defining whether to compile in UPNP or not, and apparently it does do that as well. I built bitcoind with and without UPNP using the makefile ifeq I specified above and setting 1/0 respectively which I could have just commented it out instead. Sorry for that.
trentzb closed this on Apr 21, 2011
zathras-crypto referenced this in commit 82dbd22b83 on Oct 23, 2014
sipa referenced this in commit 7873633b57 on Jan 5, 2015
TheBlueMatt referenced this in commit 582b2934e6 on Oct 20, 2015
deadalnix referenced this in commit 30db8db426 on Dec 13, 2016
deadalnix referenced this in commit 7767b4d25b on Jan 19, 2017
lateminer referenced this in commit e06085674f on Dec 9, 2017
classesjack referenced this in commit a6ef3a730b on Jan 2, 2018
attilaaf referenced this in commit 1372688a00 on Jan 13, 2020
cryptapus referenced this in commit 294324068d on Feb 18, 2020
Losangelosgenetics referenced this in commit bbdcdffb12 on Mar 12, 2020
rajarshimaitra referenced this in commit d1ae621bb4 on Aug 5, 2021
rajarshimaitra referenced this in commit cbbf9594ae on Aug 5, 2021
rajarshimaitra referenced this in commit 73ab568bbf on Aug 5, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

trentzb

gavinandresen

Linked (view graph)

#33 Fix statusbar color #25323 miniscript fuzzer failing after qa-assets update