IsStandardTx() returns rejection reason "bare-multisig" if any one of the outputs’ scriptPubKey has bare multisignature format (i.e. M <PubKey1> <PubKey2> ... <PubKeyN> N OP_CHECKSIG, not P2SH!) and the policy flag fIsBareMultisigStd is set to false.
permitbaremultisig has no tests either, good you’re working through these.
796@@ -797,6 +797,17 @@ BOOST_AUTO_TEST_CASE(test_IsStandard)
797 reason.clear();
798 BOOST_CHECK(!IsStandardTx(CTransaction(t), reason));
799 BOOST_CHECK_EQUAL(reason, "scriptsig-size");
800+
801+ // Check bare multisig (standard if policy flag fIsBareMultisigStd is set)
802+ fIsBareMultisigStd = true;
803+ t.vout[0].scriptPubKey = GetScriptForMultisig(2, std::vector<CPubKey>(3, key.GetPubKey())); // 2-of-3
For this test I think you should do the simplest base case to make it trivially certain you’re not hitting some size-based restriction(as I recall, naked multisigs increase virtual size of transactions during relay….)
so just make a 1-of-1 multisig
The function IsStandardTx() returns rejection reason "bare-multisig" if the
transaction has a bare multisig output and the policy flag fIsBareMultisigStd
is false (set by the boolean command-line argument "-permitbaremultisig" -- for
the unit test, we simply set the global flag variable directly).
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
