Only WalletTool::ExecuteWalletToolFunc() is used outside of this translation unit.
Other functions are moved to the unnamed namespace.
refactor, tool: Cleanup WalletTool namespace #17516
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20191119-wallettool-namespace changing 3 files +15 −9-
hebasto commented at 4:48 PM on November 19, 2019: member
-
refactor: Cleanup WalletTool namespace b25f0ba77d
-
MarcoFalke commented at 4:59 PM on November 19, 2019: member
Tend to NACK without motivation. This makes writing unit tests harder and looks like needless code churn.
- hebasto closed this on Nov 19, 2019
-
laanwj commented at 11:21 AM on November 20, 2019: member
Yeah, not polluting the global namespace is a good aim for utilities, not so much for main compilation units.
- hebasto deleted the branch on Nov 20, 2019
- MarcoFalke locked this on Dec 16, 2021
Contributors