rpc: Remove unused COINBASE_FLAGS #17519

pull narula wants to merge 1 commits into bitcoin:master from narula:removecoinbaseflags changing 4 files +2 −9

narula commented at 6:12 PM on November 19, 2019: contributor

Commit d449772cf69c01932fc5d72c46054815d6300b3c stopped setting COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.

Following up on #17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.
fanquake added the label Refactoring on Nov 19, 2019
in src/rpc/mining.cpp:610 in 9aedabe67e outdated
```
 606 | @@ -607,7 +607,6 @@ static UniValue getblocktemplate(const JSONRPCRequest& request)
 607 |      }
 608 |  
 609 |      UniValue aux(UniValue::VOBJ);
 610 | -    aux.pushKV("flags", HexStr(COINBASE_FLAGS.begin(), COINBASE_FLAGS.end()));
```
MarcoFalke commented at 6:29 PM on November 19, 2019:

Not sure what the implications of removing this field are, as I don't have strong knowledge of the getblocktemplate BIP. Though, when this is removed, the documentation in RPCHelpMan should be updated as well. And maybe aux can be removed as well? cc @luke-jr

luke-jr commented at 6:58 PM on November 19, 2019:

I'm not sure this counts as simple refactoring. Maybe rename the PR and make it a separate commit?

luke-jr commented at 6:59 PM on November 19, 2019:

It looks like "flags" is entirely missing in the BIPs.

luke-jr commented at 7:01 PM on November 19, 2019:

(Also not supported by either Eloipool nor libblkmaker)

MarcoFalke commented at 7:14 PM on November 19, 2019:

ok, but coinbaseaux is: https://en.bitcoin.it/wiki/BIP_0022#Specification

So I guess aux should stay but be kept empty.

MarcoFalke commented at 7:15 PM on November 19, 2019:

Done (renamed title)
MarcoFalke approved
MarcoFalke commented at 6:29 PM on November 19, 2019: member

ACK
MarcoFalke renamed this:
~~refactor: Remove unused COINBASE_FLAGS~~
rpc: Remove unused COINBASE_FLAGS
on Nov 19, 2019
MarcoFalke removed the label Refactoring on Nov 19, 2019
MarcoFalke added the label RPC/REST/ZMQ on Nov 19, 2019
laanwj commented at 9:02 AM on November 20, 2019: member

ACK 9aedabe67eedfee9c94c6a50962f11348eb99bca ACK e9a27cf338dc618b8ecab8984abc54d588de8a05
narula commented at 7:51 PM on November 20, 2019: contributor

I can update RPCHelpMan. Is the right way to do that just remove flags, or would you prefer it to be marked in some way?

Does it make sense to remove the coinbaseaux flag as well?
laanwj commented at 8:04 PM on November 20, 2019: member

I can update RPCHelpMan. Is the right way to do that just remove flags, or would you prefer it to be marked in some way?

To remove it, so that the help matches the output.

Does it make sense to remove the coinbaseaux flag as well?

It's part of the BIP according to @luke-jr so I think it'd be better to keep it but leave it empty, as @MarcoFalke says.
jnewbery commented at 8:28 PM on November 20, 2019: member

utACK 9aedabe67eedfee9c94c6a50962f11348eb99bca once flags has been removed from the help text.

refactor: Remove unused COINBASE_FLAGS

Commit d449772cf69c01932fc5d72c46054815d6300b3c stopped setting
COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.
Update the help string to remove "flags", which is not specified in
BIP 22.

e9a27cf338

narula force-pushed on Nov 21, 2019
narula commented at 12:10 AM on November 21, 2019: contributor

Updated to remove flags.

MarcoFalke commented at 7:10 PM on November 21, 2019: member

ACK e9a27cf338dc618b8ecab8984abc54d588de8a05 💻

<details><summary>Show signature and timestamp</summary>

Signature:

Timestamp of file with hash 4af5f8707e419046118b148a954e705aa3ec85e3d60b38b9f3a0e1e32ec1cb31 -

</details>

laanwj referenced this in commit a739d207a3 on Nov 22, 2019
laanwj merged this on Nov 22, 2019
laanwj closed this on Nov 22, 2019
sidhujag referenced this in commit c9cd991cc2 on Nov 22, 2019
MarkLTZ referenced this in commit cb97b89084 on Nov 29, 2019
jasonbcox referenced this in commit 09759c8f87 on Nov 5, 2020
sidhujag referenced this in commit c3b9f4d646 on Nov 10, 2020
vijaydasmp referenced this in commit aa0e130d38 on Aug 29, 2021
vijaydasmp referenced this in commit 12fef2db71 on Aug 29, 2021
vijaydasmp referenced this in commit 079e4a38ae on Aug 29, 2021
vijaydasmp referenced this in commit 7f95090820 on Aug 29, 2021
vijaydasmp referenced this in commit fb515cf5bb on Aug 30, 2021
vijaydasmp referenced this in commit 29a3f26fa5 on Aug 30, 2021
PastaPastaPasta referenced this in commit c417db87c9 on Aug 31, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17489 Remove unused variable COINBASE_FLAGS