- this is already active for bitcoin-qt.exe
As no one responded in the IRC chan I'll open this as pull. I'm not sure if that pull needs further modifications to the makefiles, so please be gentle :).
As no one responded in the IRC chan I'll open this as pull. I'm not sure if that pull needs further modifications to the makefiles, so please be gentle :).
Looks fine. Let's wait for the pulltester to see whether the linker args are really passed.
This will not work yet: LDFLAGS is not passed when linking. You need to add $(LDFLAGS) to the lines that build bitcoind.exe and test_bitcoin.exe, i.e. in makefile.mingw-linux these are
i586-mingw32msvc-g++ $(CFLAGS) -o $@ $(LIBPATHS) $^ $(LIBS)
and
i586-mingw32msvc-g++ $(CFLAGS) -o $@ $(LIBPATHS) $^ -lboost_unit_test_framework-mt-s $(LIBS)
- this is already active for bitcoin-qt.exe
Yes, looks OK now.