wallet: Remove out of date comments for CalculateMaximumSignedTxSize #17553

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:calc_max_size_comment changing 1 files +1 −5

instagibbs commented at 7:40 PM on November 21, 2019: member

These paths can be hit for probably a number of reasons, and ISMINE spendability is not a requirement to call it.

For example: During watch-only transaction creation, previous transaction in wallet, pubkey imported, but not the witnessscript associated with the prevout.

In this case I think no/minimal comment is better than specific and soon to be out of date.
Remove out of date comments for CalculateMaximumSignedTxSize 6a2e6b0600
instagibbs commented at 7:41 PM on November 21, 2019: member

cc @achow101
fanquake added the label Wallet on Nov 21, 2019
achow101 commented at 10:45 PM on November 21, 2019: member

ACK 6a2e6b0600077e5903400dc74bc8b0c26592fde6
fanquake requested review from meshcollider on Nov 21, 2019
fanquake renamed this:
~~Remove out of date comments for CalculateMaximumSignedTxSize~~
wallet: Remove out of date comments for CalculateMaximumSignedTxSize
on Nov 21, 2019
DrahtBot commented at 12:44 AM on November 22, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17211 (Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
darosior approved
darosior commented at 11:00 AM on November 22, 2019: member

ACK 6a2e6b0600077e5903400dc74bc8b0c26592fde6
meshcollider commented at 8:33 PM on November 22, 2019: contributor

Sounds good to me 6a2e6b0600077e5903400dc74bc8b0c26592fde6
meshcollider referenced this in commit 2a97d2b1a5 on Nov 22, 2019
meshcollider merged this on Nov 22, 2019
meshcollider closed this on Nov 22, 2019
sidhujag referenced this in commit bdceceee0a on Nov 22, 2019
MarkLTZ referenced this in commit 7937f8d1ff on Nov 29, 2019
jasonbcox referenced this in commit 903e524b88 on Sep 30, 2020
sidhujag referenced this in commit 145399597d on Nov 10, 2020
PastaPastaPasta referenced this in commit d249df1aa5 on Sep 25, 2021
PastaPastaPasta referenced this in commit d54e7c8197 on Sep 28, 2021
kittywhiskers referenced this in commit 1f255a9df3 on Oct 12, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

wallet: Remove out of date comments for CalculateMaximumSignedTxSize #17553

Conflicts