Test PSBT creation in GUI #17588

1. 
   Sjors commented at 10:45 am on November 25, 2019: member

   #16944 added support for creating a PSBT in the GUI, when using a watch-only wallet.

   It would be useful to test this functionally, by expanding the tests here: https://github.com/bitcoin/bitcoin/blob/master/src/qt/test/wallettests.cpp#L173-L180

   The test should also check the balance in the send screen, see #17587.

2. Sjors added the label good first issue on Nov 25, 2019
3. 
   brakmic commented at 9:11 pm on December 16, 2019: contributor

   @Sjors

   I’ve added a test-case for PSBT in my repo, but before opening a PR maybe we should check if it’s acceptable at all.

   https://github.com/brakmic/bitcoin/commit/b8f3e84f21f7bb9ef423210543ebe227820aef60

   First, I’ve tried to create a transaction by using QT dialogs without much success. Therefore, I imported two BuildTransaction-Functions from other tests to create the needed transaction that could be used to initialize a PSBT.

   Regarding testing the balance in send screen: I still have to figure it out. :)

4. 
   Sjors commented at 4:24 pm on December 21, 2019: member

   @brakmic at first glance it seems that you’re not testing anything QT related there; CMutableTransaction might as well be tested with bitcoind. Same with walletModel.wallet() which just points to the wallet interface.
5. 
   Sjors commented at 12:31 pm on January 6, 2021: member

   Closing because GUI tests in general need work.
6. Sjors closed this on Jan 6, 2021

   ---

7. DrahtBot locked this on Aug 18, 2022

Contributors
Sjors brakmic

Labels
good first issue