qt: Remove connection for unused accepted() signal in ReceiveRequestDialog #17600

1. 
   hebasto commented at 8:30 pm on November 25, 2019: member

   ReceiveRequestDialog has only “Close” button in QDialogButtonBox, therefore nothing could emit QDialogButtonBox::accepted() signal.
2. qt: Remove connection for unused accepted() signal a1d22e16a8
3. fanquake added the label GUI on Nov 25, 2019
4. 
   promag commented at 11:44 pm on November 25, 2019: member

   Isn’t always clear to me which role should be used in these cases. Here the payment request was created right before opening the dialog - so what could we “reject”? I think the most appropriate role is “accept” as there’s no alternative operation, there’s nothing you can do with it. - or is there some guidelines I’m not aware of?

   So maybe change the button role and drop the connection from reject signal?

   Either way concept ACK.

5. 
   hebasto commented at 0:13 am on November 26, 2019: member

   @promag

   Here the payment request was created right before opening the dialog - so what could we “reject”?

   Maybe there should be “OK” button, not “Close”?

6. 
   jonasschnelli commented at 2:16 am on November 26, 2019: contributor

   Successfully tested by setting a breakpoint at ReceiveCoinsDialog::reject() (never reached). I guess you should also remove the method and definition ReceiveCoinsDialog::reject() in receivecoinsdialog.h/.cpp`
7. 
   laanwj commented at 12:18 pm on November 27, 2019: member

   Successfully tested by setting a breakpoint at ReceiveCoinsDialog::reject() (never reached).

   Hhmm but doesn’t this remove the slot setup for accept(), not reject()?

8. 
   hebasto commented at 1:05 pm on November 27, 2019: member

   Successfully tested by setting a breakpoint at ReceiveCoinsDialog::reject() (never reached).

   Hhmm but doesn’t this remove the slot setup for accept(), not reject()?

   Actually, ReceiveCoinsDialog and ReceiveRequestDialog are different classes ;)

   And “yes”, this PR removes connection to ReceiveRequestDialog::accept() slot.

9. 
   hebasto commented at 10:48 pm on December 5, 2019: member

   Closed in favor of #17597.
10. hebasto closed this on Dec 5, 2019

    ---

11. hebasto deleted the branch on Dec 7, 2019
12. MarcoFalke locked this on Dec 16, 2021

Contributors
hebasto promag jonasschnelli laanwj

Labels
GUI