ReceiveRequestDialog has only "Close" button in QDialogButtonBox, therefore nothing could emit QDialogButtonBox::accepted() signal.
qt: Remove connection for unused accepted() signal in ReceiveRequestDialog #17600
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20191125-unused-connection changing 1 files +0 −16-
hebasto commented at 8:30 PM on November 25, 2019: member
-
qt: Remove connection for unused accepted() signal a1d22e16a8
- fanquake added the label GUI on Nov 25, 2019
-
promag commented at 11:44 PM on November 25, 2019: member
Isn't always clear to me which role should be used in these cases. Here the payment request was created right before opening the dialog - so what could we "reject"? I think the most appropriate role is "accept" as there's no alternative operation, there's nothing you can do with it. - or is there some guidelines I'm not aware of?
So maybe change the button role and drop the connection from reject signal?
Either way concept ACK.
-
-
jonasschnelli commented at 2:16 AM on November 26, 2019: contributor
Successfully tested by setting a breakpoint at
ReceiveCoinsDialog::reject()(never reached). I guess you should also remove the method and definitionReceiveCoinsDialog::reject()in receivecoinsdialog.h/.cpp` -
laanwj commented at 12:18 PM on November 27, 2019: member
Successfully tested by setting a breakpoint at ReceiveCoinsDialog::reject() (never reached).
Hhmm but doesn't this remove the slot setup for
accept(), notreject()? -
hebasto commented at 1:05 PM on November 27, 2019: member
Successfully tested by setting a breakpoint at ReceiveCoinsDialog::reject() (never reached).
Hhmm but doesn't this remove the slot setup for
accept(), notreject()?Actually,
ReceiveCoinsDialogandReceiveRequestDialogare different classes ;)And "yes", this PR removes connection to
ReceiveRequestDialog::accept()slot. -
- hebasto closed this on Dec 5, 2019
- hebasto deleted the branch on Dec 7, 2019
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels