qt, refactor: Use proper classes for Ui::* #17606

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20191125-fix-ui-baseclass changing 2 files +2 −10

hebasto commented at 12:40 AM on November 26, 2019: member
Use proper classes for:
- Ui::ModalOverlay to remove <customwidget> entry
- Ui::ReceiveCoinsDialog to be consistent with the code base
This PR does not change behavior.
qt: Fix class name of Ui::ModalOverlay 8781904643
qt: Use proper class for Ui::ReceiveCoinsDialog 93352d261f
fanquake added the label GUI on Nov 26, 2019
jonasschnelli commented at 2:04 AM on November 26, 2019: contributor

Tested ACK 93352d261fa4e1518a4f006de157ff5a2fc4c819 - ran this on top of master and tested the modal overlay on initial mainnet sync.

in src/qt/forms/modaloverlay.ui:4 in 93352d261f

   0 | @@ -1,7 +1,7 @@
   1 |  <?xml version="1.0" encoding="UTF-8"?>
   2 |  <ui version="4.0">
   3 |   <class>ModalOverlay</class>
   4 | - <widget class="ModalOverlay" name="ModalOverlay">
   5 | + <widget class="QWidget" name="ModalOverlay">

laanwj commented at 10:33 AM on November 26, 2019:

Right, a customwidget entry for the top-level widget is always unnecessary, as it's not instantiated by the generated code.

laanwj commented at 10:36 AM on November 26, 2019: member

code review ACK 93352d261fa4e1518a4f006de157ff5a2fc4c819
fanquake referenced this in commit f2ab130961 on Nov 26, 2019
fanquake merged this on Nov 26, 2019
fanquake closed this on Nov 26, 2019
hebasto deleted the branch on Nov 27, 2019
MarkLTZ referenced this in commit aa93463274 on Nov 29, 2019
deadalnix referenced this in commit eb412c7dca on Sep 28, 2020
PastaPastaPasta referenced this in commit 1803a557a8 on Jun 27, 2021
PastaPastaPasta referenced this in commit 8f4186f0f5 on Jun 28, 2021
PastaPastaPasta referenced this in commit 41633a2aa6 on Jun 29, 2021
PastaPastaPasta referenced this in commit cc867330d1 on Jul 1, 2021
PastaPastaPasta referenced this in commit 3ba95057dc on Jul 1, 2021
PastaPastaPasta referenced this in commit ecf5315426 on Jul 14, 2021
PastaPastaPasta referenced this in commit 110cc0ed70 on Jul 14, 2021
PastaPastaPasta referenced this in commit 316ae85508 on Jul 15, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels