When I use the option with the default keyserver on gpg (GnuPG) 2.2.12 from the Debian repositories only the keys from meshcollider and fanquake are actually found. Using the ubuntu keyserver works without any problems and all keys are getting found.
As this keyserver is also suggested on https://bitcoincore.org/en/download/, it would be good to have a common keyserver.
script: Add Keyserver to verify-commits README #17637
pull emilengler wants to merge 1 commits into bitcoin:master from emilengler:2019-11-add-keyserver-to-verify-commit-readme changing 1 files +1 −1-
emilengler commented at 3:38 AM on November 30, 2019: contributor
- emilengler renamed this:
Add Keyserver to verify-commits README
script: Add Keyserver to verify-commits README
on Nov 30, 2019 -
script: Add Keyserver to verify-commits README bd6a243075
- emilengler force-pushed on Nov 30, 2019
- DrahtBot added the label Docs on Nov 30, 2019
- DrahtBot added the label Scripts and tools on Nov 30, 2019
- paymog approved
-
paymog commented at 8:53 AM on November 30, 2019: none
LGTM
10:52AM /Users/paymahn/bitcoin master ❮❮❮ gpg --recv-keys $(<contrib/verify-commits/trusted-keys) gpg: key 944D35F9AC3DB76A: public key "Michael Ford (bitcoin-otc) <fanquake@gmail.com>" imported gpg: key D300116E1C875A3D: public key "MeshCollider <dobsonsa68@gmail.com>" imported gpg: key 3648A882F4316B9B: new key but contains no user ID - skipped gpg: key 29D4BCB6416F53EC: new key but contains no user ID - skipped gpg: key 860FEB804E669320: new key but contains no user ID - skipped gpg: key 74810B012346C9A6: new key but contains no user ID - skipped gpg: Total number processed: 6 gpg: w/o user IDs: 4 gpg: imported: 2 10:52AM /Users/paymahn/bitcoin master ❯❯❯ gpg --keyserver hkp://keyserver.ubuntu.com --recv-keys $(<contrib/verify-commits/trusted-keys) gpg: key 944D35F9AC3DB76A: "Michael Ford (bitcoin-otc) <fanquake@gmail.com>" not changed gpg: key D300116E1C875A3D: "MeshCollider <dobsonsa68@gmail.com>" not changed gpg: key 3648A882F4316B9B: public key "Marco Falke <marco.falke@tum.de>" imported gpg: key 29D4BCB6416F53EC: public key "Jonas Schnelli <dev@jonasschnelli.ch>" imported gpg: key 860FEB804E669320: public key "Pieter Wuille <pieter.wuille@gmail.com>" imported gpg: key 74810B012346C9A6: public key "Wladimir J. van der Laan <laanwj@visucore.com>" imported gpg: Total number processed: 6 gpg: imported: 4 gpg: unchanged: 2 - fanquake removed the label Scripts and tools on Nov 30, 2019
-
emilengler commented at 2:08 PM on November 30, 2019: contributor
-
paymog commented at 7:00 AM on December 1, 2019: none
Thank you! Understood, I'll probably make more mistakes as I ramp up on Bitcoin but I intend to help review and write code.
On Sat, Nov 30, 2019 at 4:08 PM Emil Engler notifications@github.com wrote:
@paymog https://github.com/paymog Welcome to Bitcoin Core :) We don't use terms like LGTM here. We have list of our "slang" here https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review . In your case you probably meant "ACK"
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/17637?email_source=notifications&email_token=AAPFDBQIOBUH7SYTY6H44TTQWJXW5A5CNFSM4JTEX5W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQH6OA#issuecomment-559972152, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPFDBSUBVBW54EZ6GWNHGLQWJXW5ANCNFSM4JTEX5WQ .
-
laanwj commented at 4:29 PM on December 3, 2019: member
ACK bd6a24307564a56d54d98331d5e1680d27ddc09e, better to be explicit here
- MarcoFalke referenced this in commit e354db7877 on Dec 3, 2019
- MarcoFalke merged this on Dec 3, 2019
- MarcoFalke closed this on Dec 3, 2019
- sidhujag referenced this in commit 62166f0cbf on Dec 3, 2019
- sidhujag referenced this in commit f93fa0619b on Nov 10, 2020
- PastaPastaPasta referenced this in commit 35ad97b8a3 on Sep 17, 2021
- thelazier referenced this in commit 3917672197 on Sep 25, 2021
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels