gui: increases default GraphRange of Network Traffic to 12 hours. #17645

pull CynicusRex wants to merge 1 commits into bitcoin:master from CynicusRex:GraphRange changing 1 files +1 −1
  1. CynicusRex commented at 6:19 PM on December 1, 2019: none
    1. A graph range of 12 h shows a more informative overview of the daily traffic.
    2. It's annoying to increase this range after every reboot; 12 hours is right in the middle, so users who want to change it have to drag the slider less compared to the original value.

    Value 6 = 30 minutes (6 * 5 m), value 144 = 12 hours (144 * 5 m).

  2. gui: increases default GraphRange of Network Traffic to 12 hours. 21936e9739
  3. fanquake added the label GUI on Dec 1, 2019
  4. chris-belcher commented at 6:59 PM on December 1, 2019: contributor

    Concept ACK

  5. CynicusRex commented at 8:00 PM on December 1, 2019: none

    No idea what caused this error. I edited the value in Visual Studio Code and saved it. This is the console output during the process: https://pastebin.com/FCCEHdjt. You can see I initially merged the branch to my master and pushed it, instead of pushing the branch directly—which I did afterward.

  6. jonasschnelli commented at 8:59 PM on December 1, 2019: contributor

    Unsure about this...

    1. Running this commit, the initial displayed value is 30min, when I slider forth and back to the same position, it states 12h (bug).
    2. Using a 12h window makes the graph black for a minute or so (including the grid) which is non-ideal for a user feedback (probably acceptable since not directly related to this change).
  7. CynicusRex commented at 9:49 PM on December 1, 2019: none

    @jonasschnelli To be a nitpicker:

    1. 30 m and 12 h [in case someone tries to ctrl+f 'min']
    2. ~53 seconds.

    Anyway, I agree that both consequences are annoying; the former being unacceptable.

  8. hebasto commented at 11:14 AM on December 7, 2019: member
    • Using a 12h window makes the graph black for a minute or so (including the grid) which is non-ideal for a user feedback (probably acceptable since not directly related to this change).

    This behavior is observed on master branch too.

  9. MarkLTZ referenced this in commit 33265da2a5 on Dec 17, 2019
  10. laanwj commented at 7:13 PM on March 27, 2020: member

    There doesn't seem to be agreement on doing this and the PR has been inactive for months, closing.

  11. laanwj closed this on Mar 27, 2020

  12. MarkLTZ referenced this in commit 6e615ed052 on Nov 17, 2020
  13. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me